[PATCHSET 1/2] fstests: random fixes for v2024.09.29

[PATCHSET 1/2] fstests: random fixes for v2024.09.29

[Darrick J. Wong]

Hi all,

Here's the usual odd fixes for fstests.  Most of these are cleanups and
bug fixes that have been aging in my djwong-wtf branch forever.

If you're going to start using this code, I strongly recommend pulling
from my git trees, which are linked below.

With a bit of luck, this should all go splendidly.
Comments and questions are, as always, welcome.

--D

kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=random-fixes

xfsprogs git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=random-fixes

fstests git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=random-fixes
---
Commits in this patchset:
 * common/populate: fix bash syntax error in _fill_fs
---
 common/populate |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 1/1] common/populate: fix bash syntax error in _fill_fs

[Darrick J. Wong]

From: Darrick J. Wong <djwong@kernel.org>

In bash, one does not set a variable by prepending the dollar sign to
the variable name.  Amazingly, this was copied verbatim from generic/256
in 2016 and hasn't been caught since its introduction in 2011. :(

Cc: allison.henderson@oracle.com
Fixes: 815015e9ee ("generic: make 17[1-4] work well when btrfs compression is enabled")
Fixes: b55fb0807c ("xfstests: Add ENOSPC Hole Punch Test")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 common/populate |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff --git a/common/populate b/common/populate
index 9fda19df06..88c8ba2b32 100644
--- a/common/populate
+++ b/common/populate
@@ -945,7 +945,7 @@ _fill_fs()
 	echo $testio | grep -q "Operation not supported" && use_falloc=0
 
 	if [ $file_size -lt $block_size ]; then
-		$file_size = $block_size
+		file_size=$block_size
 	fi
 
 	while [ $file_size -ge $block_size ]; do

Re: [PATCH 1/1] common/populate: fix bash syntax error in _fill_fs

[Christoph Hellwig]

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>