* [PATCH] xfs/008: fix golden output for 512 fsblock size
@ 2025-05-08 7:41 Anthony Iliopoulos
2025-05-08 15:12 ` Darrick J. Wong
2025-05-11 14:29 ` Zorro Lang
0 siblings, 2 replies; 4+ messages in thread
From: Anthony Iliopoulos @ 2025-05-08 7:41 UTC (permalink / raw)
To: fstests
commit 97989c9839dd ("xfs/008: use block size instead of the pagesize")
changed the test filter, which causes nocrc/512b fsblock configurations
to fail due to mismatch of the golden output. Update it to match the
expected output.
Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
---
tests/xfs/008.out | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/xfs/008.out b/tests/xfs/008.out
index 0941e218c7d0..dc999156dab5 100644
--- a/tests/xfs/008.out
+++ b/tests/xfs/008.out
@@ -8,7 +8,7 @@ randholes.2 : -l FSIZE -c 100 -b BLKSIZE
------------------------------------------
holes is in range
-randholes.3 : -l FSIZE -c 100 -b 512
+randholes.3 : -l FSIZE -c 100 -b BLKSIZE
------------------------------------------
holes is in range
--
2.49.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] xfs/008: fix golden output for 512 fsblock size
2025-05-08 7:41 [PATCH] xfs/008: fix golden output for 512 fsblock size Anthony Iliopoulos
@ 2025-05-08 15:12 ` Darrick J. Wong
2025-05-11 14:29 ` Zorro Lang
1 sibling, 0 replies; 4+ messages in thread
From: Darrick J. Wong @ 2025-05-08 15:12 UTC (permalink / raw)
To: Anthony Iliopoulos; +Cc: fstests
On Thu, May 08, 2025 at 09:41:02AM +0200, Anthony Iliopoulos wrote:
> commit 97989c9839dd ("xfs/008: use block size instead of the pagesize")
> changed the test filter, which causes nocrc/512b fsblock configurations
> to fail due to mismatch of the golden output. Update it to match the
> expected output.
>
> Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
Looks good to me,
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
--D
> ---
> tests/xfs/008.out | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/008.out b/tests/xfs/008.out
> index 0941e218c7d0..dc999156dab5 100644
> --- a/tests/xfs/008.out
> +++ b/tests/xfs/008.out
> @@ -8,7 +8,7 @@ randholes.2 : -l FSIZE -c 100 -b BLKSIZE
> ------------------------------------------
> holes is in range
>
> -randholes.3 : -l FSIZE -c 100 -b 512
> +randholes.3 : -l FSIZE -c 100 -b BLKSIZE
> ------------------------------------------
> holes is in range
>
> --
> 2.49.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] xfs/008: fix golden output for 512 fsblock size
2025-05-08 7:41 [PATCH] xfs/008: fix golden output for 512 fsblock size Anthony Iliopoulos
2025-05-08 15:12 ` Darrick J. Wong
@ 2025-05-11 14:29 ` Zorro Lang
2025-05-11 19:01 ` Anthony Iliopoulos
1 sibling, 1 reply; 4+ messages in thread
From: Zorro Lang @ 2025-05-11 14:29 UTC (permalink / raw)
To: Anthony Iliopoulos; +Cc: fstests
On Thu, May 08, 2025 at 09:41:02AM +0200, Anthony Iliopoulos wrote:
> commit 97989c9839dd ("xfs/008: use block size instead of the pagesize")
> changed the test filter, which causes nocrc/512b fsblock configurations
> to fail due to mismatch of the golden output. Update it to match the
> expected output.
>
> Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
> ---
> tests/xfs/008.out | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/008.out b/tests/xfs/008.out
> index 0941e218c7d0..dc999156dab5 100644
> --- a/tests/xfs/008.out
> +++ b/tests/xfs/008.out
> @@ -8,7 +8,7 @@ randholes.2 : -l FSIZE -c 100 -b BLKSIZE
> ------------------------------------------
> holes is in range
>
> -randholes.3 : -l FSIZE -c 100 -b 512
> +randholes.3 : -l FSIZE -c 100 -b BLKSIZE
This change fix the failure on nocrc/512b fsblock, but it causes xfs/008
fail on all other blocksize xfs.
-randholes.3 : -l FSIZE -c 100 -b BLKSIZE
+randholes.3 : -l FSIZE -c 100 -b 512
Thanks,
Zorro
> ------------------------------------------
> holes is in range
>
> --
> 2.49.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] xfs/008: fix golden output for 512 fsblock size
2025-05-11 14:29 ` Zorro Lang
@ 2025-05-11 19:01 ` Anthony Iliopoulos
0 siblings, 0 replies; 4+ messages in thread
From: Anthony Iliopoulos @ 2025-05-11 19:01 UTC (permalink / raw)
To: Zorro Lang; +Cc: fstests
On Sun, May 11, 2025 at 10:29:54PM +0800, Zorro Lang wrote:
> On Thu, May 08, 2025 at 09:41:02AM +0200, Anthony Iliopoulos wrote:
> > commit 97989c9839dd ("xfs/008: use block size instead of the pagesize")
> > changed the test filter, which causes nocrc/512b fsblock configurations
> > to fail due to mismatch of the golden output. Update it to match the
> > expected output.
> >
> > Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
> > ---
> > tests/xfs/008.out | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/xfs/008.out b/tests/xfs/008.out
> > index 0941e218c7d0..dc999156dab5 100644
> > --- a/tests/xfs/008.out
> > +++ b/tests/xfs/008.out
> > @@ -8,7 +8,7 @@ randholes.2 : -l FSIZE -c 100 -b BLKSIZE
> > ------------------------------------------
> > holes is in range
> >
> > -randholes.3 : -l FSIZE -c 100 -b 512
> > +randholes.3 : -l FSIZE -c 100 -b BLKSIZE
>
> This change fix the failure on nocrc/512b fsblock, but it causes xfs/008
> fail on all other blocksize xfs.
Indeed, thanks for catching this, I'll send a v2 with the corresponding
filter fix.
Regards,
Anthony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-05-11 19:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-08 7:41 [PATCH] xfs/008: fix golden output for 512 fsblock size Anthony Iliopoulos
2025-05-08 15:12 ` Darrick J. Wong
2025-05-11 14:29 ` Zorro Lang
2025-05-11 19:01 ` Anthony Iliopoulos
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox