From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <wqu@suse.com>
Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
Xiao Yang <yangx.jy@fujitsu.com>
Subject: Re: [PATCH RFC] fstests: use MOUNT_OPTIONS to populate TEST_FS_MOUNT_OPTS if possible
Date: Mon, 1 Jun 2026 23:13:01 -0700 [thread overview]
Message-ID: <ah50bZRaH6YWTJXc@infradead.org> (raw)
In-Reply-To: <20260602001422.24364-1-wqu@suse.com>
On Tue, Jun 02, 2026 at 09:44:22AM +0930, Qu Wenruo wrote:
> If the test config only specifies "MOUNT_OPTIONS", but not
> "TEST_FS_MOUNT_OPTS", the mount for TEST_DIR can have inconsistent flag
> after _test_cycle_mount().
AFAIK TEST_FS_MOUNT_OPTS gets overriden and isn't even a public option.
It gets filled by fstype-sepcific options in _common_mount_opts.
This started to really confuse me lately when I was trying to test with
mount options on the test fs.
I've looked at bit into the area but haven't come to a conclusion yet.
The most recent change in this area is 1dd7395623cb ("common/config:
Make test and scratch devices use the same mount options"), which didn't
really make them common, adding to my confusion.
So I really think we need to fix things here, but right now I'm not sure
how much of the current situation is intentional, and what our final
goal is :(
next prev parent reply other threads:[~2026-06-02 6:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 0:14 [PATCH RFC] fstests: use MOUNT_OPTIONS to populate TEST_FS_MOUNT_OPTS if possible Qu Wenruo
2026-06-02 6:13 ` Christoph Hellwig [this message]
2026-06-04 16:46 ` Zorro Lang
2026-06-05 4:13 ` Christoph Hellwig
2026-06-06 19:33 ` Zorro Lang
2026-06-04 17:48 ` Zorro Lang
2026-06-06 9:22 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah50bZRaH6YWTJXc@infradead.org \
--to=hch@infradead.org \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
--cc=yangx.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox