From: Christoph Hellwig <hch@infradead.org>
To: Christoph Hellwig <hch@infradead.org>, Qu Wenruo <wqu@suse.com>,
fstests@vger.kernel.org, linux-btrfs@vger.kernel.org,
Xiao Yang <yangx.jy@fujitsu.com>
Subject: Re: [PATCH RFC] fstests: use MOUNT_OPTIONS to populate TEST_FS_MOUNT_OPTS if possible
Date: Thu, 4 Jun 2026 21:13:30 -0700 [thread overview]
Message-ID: <aiJM6o982CKp7v_y@infradead.org> (raw)
In-Reply-To: <aiGYgLaQ7_r9LQ2G@zlang-mailbox>
On Fri, Jun 05, 2026 at 12:46:13AM +0800, Zorro Lang wrote:
> Right now, the biggest inconsistent issue is probably with those feature-probing
> helpers. They often check TEST_DIR to determine behaviors for SCRATCH_MNT. While
> this works fine for features unaffected by mount options, but we might should
> handle mount options related features (for TEST_DEV or SCRATCH_DEV) separately.
Yes, I've run into a lot of issues when TEST_DIR has more feature than
SCRATCH_DEV. The problem is just that feature testing for scratch is
a bit annoying because we have to create a file system for it first.
It might make sense to catch some of the results, but then again we have
tests that override options for the scratch side so that this won't
apply.
I've been wanting to look into splitting the scratch tests up into those
that "just" format the file systems, and those testing very specific
corners cases using special options. Especially as we should not have
to run the latter multiple times for different configurations.
next prev parent reply other threads:[~2026-06-05 4:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 0:14 [PATCH RFC] fstests: use MOUNT_OPTIONS to populate TEST_FS_MOUNT_OPTS if possible Qu Wenruo
2026-06-02 6:13 ` Christoph Hellwig
2026-06-04 16:46 ` Zorro Lang
2026-06-05 4:13 ` Christoph Hellwig [this message]
2026-06-06 19:33 ` Zorro Lang
2026-06-04 17:48 ` Zorro Lang
2026-06-06 9:22 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aiJM6o982CKp7v_y@infradead.org \
--to=hch@infradead.org \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
--cc=yangx.jy@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox