From: Christoph Hellwig <hch@infradead.org>
To: Theodore Tso <tytso@mit.edu>,
Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>,
"fstests@vger.kernel.org" <fstests@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"slava@dubeyko.com" <slava@dubeyko.com>
Subject: Re: Should we consider disable generic/563 for file systems that do not support cgroup2?
Date: Mon, 20 Jul 2026 01:07:39 -0700 [thread overview]
Message-ID: <al3XS4P7Z9lHSb_j@infradead.org> (raw)
In-Reply-To: <al0d2btWzQaFmcI5@zlang-mailbox>
On Mon, Jul 20, 2026 at 03:15:47AM +0800, Zorro Lang wrote:
> Sure, hardcoding a _notrun based on FSTYP is a last resort, and it would
> definitely be better if we had a more elegant way to trigger the _notrun.
> As a test suite, I cannot enforce or dictate what features a specific
> filesystem must export just for the convenience of testing :)
Yes. And if we have to do that it should at least be in a common helper
and not sprinkled over the tests.
> /sys/fs/$FSTYP/features/ is indeed incredibly helpful! Just a couple of
> days ago, I was actually discussing expanding _require_fs_sysfs to support
> features/ checks there, since our current checks are limited to the
> /sys/fs/$FSTYP/$device/ directory:
>
> https://lore.kernel.org/fstests/aloCfjjqesxpzL9z@zlang-mailbox/T/#mc5a0492cc00550467256951042828bef5d7fa38d
features can very much depend on the actual file system instance.
Trying to expose them globally doesn't make much sense.
prev parent reply other threads:[~2026-07-20 8:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 19:10 Should we consider disable generic/563 for file systems that do not support cgroup2? Viacheslav Dubeyko
2026-07-17 16:19 ` Zorro Lang
2026-07-17 17:42 ` Viacheslav Dubeyko
2026-07-19 14:02 ` Theodore Tso
2026-07-19 15:57 ` Zorro Lang
2026-07-19 16:52 ` Theodore Tso
2026-07-19 19:15 ` Zorro Lang
2026-07-20 8:07 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=al3XS4P7Z9lHSb_j@infradead.org \
--to=hch@infradead.org \
--cc=Slava.Dubeyko@ibm.com \
--cc=fstests@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox