From: Zorro Lang <zlang@kernel.org>
To: Theodore Tso <tytso@mit.edu>
Cc: Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>,
"fstests@vger.kernel.org" <fstests@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"slava@dubeyko.com" <slava@dubeyko.com>
Subject: Re: Should we consider disable generic/563 for file systems that do not support cgroup2?
Date: Sun, 19 Jul 2026 23:57:04 +0800 [thread overview]
Message-ID: <alzzQA9SR55FynDu@zlang-mailbox> (raw)
In-Reply-To: <alzYSGVz86d7wDXn@mit.edu>
On Sun, Jul 19, 2026 at 10:02:47AM -0400, Theodore Tso wrote:
> On Sat, Jul 18, 2026 at 12:19:52AM -0500, Zorro Lang wrote:
> >
> > 3. You can use or implement a _require_ function to check if a specific feature
> > is supported, which will gracefully _notrun the test if it's missing. While
> > _require_cgroup2() already exists, its granularity is currently too coarse to
> > _notrun for HFS. You might want to consider refining it or introducing a new
> > helper to help file systems like HFS+ _notrun properly.
>
> It may be rather challenging to determine whether the file system is
> supposed to support cgroupv2, unless we want to define a VFS specific
> flag and a way to query it via sysfs. If we want to encourage the use
> of the simpler file systems to use xfstests, we may want to consider
> that approach.
Hi Ted,
Thank you for your reply. You are right. I was just listing some possible
options, and I did not mean we must change the kernel for testing. Changing
the kernel just for a _notrun is indeed not worth it. If there is no simple
way to implement the _require_* function, we can `_exclude_fs hfs` directly :)
Thanks,
Zorro
>
> - Ted
>
next prev parent reply other threads:[~2026-07-19 15:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 19:10 Should we consider disable generic/563 for file systems that do not support cgroup2? Viacheslav Dubeyko
2026-07-17 16:19 ` Zorro Lang
2026-07-17 17:42 ` Viacheslav Dubeyko
2026-07-19 14:02 ` Theodore Tso
2026-07-19 15:57 ` Zorro Lang [this message]
2026-07-19 16:52 ` Theodore Tso
2026-07-19 19:15 ` Zorro Lang
2026-07-20 8:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alzzQA9SR55FynDu@zlang-mailbox \
--to=zlang@kernel.org \
--cc=Slava.Dubeyko@ibm.com \
--cc=fstests@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=slava@dubeyko.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox