From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: fstests@vger.kernel.org, btrfs <linux-btrfs@vger.kernel.org>,
xfs@oss.sgi.com
Subject: About reflink len = 0 behavior
Date: Thu, 20 Oct 2016 15:46:50 +0800 [thread overview]
Message-ID: <bedcb76a-4deb-bc0e-7a50-350a8a8db86f@cn.fujitsu.com> (raw)
Hi Darrick, xfs guys and btrfs guys.
Although such question is quite late as reflink generic tests are in
fstests for a long time, I'm still not sure what's the correct behavior
for reflink len = 0.
Test case generic/182 is causing different output between btrfs and xfs.
For btrfs, dedupe will just return 0 and check nothing, while for xfs
len == 0 means to check the whole file length.
Both makes sense for me, for btrfs len = 0 behavior, it just follows
read/write functions.
And I assume xfs follows reflink behavior, when len is not specified,
then reflink the length of src file.
But since it's a generic test, we need to unify the behavior.
So, which one is the standard and which document should we follow for
such behavior definition?
Thanks,
Qu
next reply other threads:[~2016-10-20 7:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 7:46 Qu Wenruo [this message]
2016-10-20 7:50 ` About reflink len = 0 behavior Qu Wenruo
2016-10-20 15:47 ` Omar Sandoval
2016-10-21 3:00 ` Darrick J. Wong
2016-10-21 5:54 ` Qu Wenruo
2016-10-21 10:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bedcb76a-4deb-bc0e-7a50-350a8a8db86f@cn.fujitsu.com \
--to=quwenruo@cn.fujitsu.com \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox