* [PATCH] fstests: check for ext3 support in btrfs/136
@ 2024-11-11 12:24 Johannes Thumshirn
2024-11-11 19:45 ` Zorro Lang
2024-11-14 9:56 ` Anand Jain
0 siblings, 2 replies; 3+ messages in thread
From: Johannes Thumshirn @ 2024-11-11 12:24 UTC (permalink / raw)
To: Zorro Lang, Anand Jain
Cc: fstests, linux-btrfs, Johannes Thumshirn, Johannes Thumshirn
Test-case btrfs/136 requires ext3 support, so check for ext3 using
_require_extra_fs.
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
tests/btrfs/136 | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/btrfs/136 b/tests/btrfs/136
index 9b5b3331119f..2a5280fb9bd1 100755
--- a/tests/btrfs/136
+++ b/tests/btrfs/136
@@ -20,6 +20,8 @@ _require_scratch_nocheck
# ext4 does not support zoned block device
_require_non_zoned_device "${SCRATCH_DEV}"
+_require_extra_fs ext3
+
_require_command "$BTRFS_CONVERT_PROG" btrfs-convert
_require_command "$MKFS_EXT4_PROG" mkfs.ext4
_require_command "$E2FSCK_PROG" e2fsck
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] fstests: check for ext3 support in btrfs/136
2024-11-11 12:24 [PATCH] fstests: check for ext3 support in btrfs/136 Johannes Thumshirn
@ 2024-11-11 19:45 ` Zorro Lang
2024-11-14 9:56 ` Anand Jain
1 sibling, 0 replies; 3+ messages in thread
From: Zorro Lang @ 2024-11-11 19:45 UTC (permalink / raw)
To: Johannes Thumshirn; +Cc: Anand Jain, fstests, linux-btrfs, Johannes Thumshirn
On Mon, Nov 11, 2024 at 01:24:53PM +0100, Johannes Thumshirn wrote:
> Test-case btrfs/136 requires ext3 support, so check for ext3 using
> _require_extra_fs.
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> ---
Makes sense to me,
Reviewed-by: Zorro Lang <zlang@redhat.com>
> tests/btrfs/136 | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/btrfs/136 b/tests/btrfs/136
> index 9b5b3331119f..2a5280fb9bd1 100755
> --- a/tests/btrfs/136
> +++ b/tests/btrfs/136
> @@ -20,6 +20,8 @@ _require_scratch_nocheck
> # ext4 does not support zoned block device
> _require_non_zoned_device "${SCRATCH_DEV}"
>
> +_require_extra_fs ext3
> +
> _require_command "$BTRFS_CONVERT_PROG" btrfs-convert
> _require_command "$MKFS_EXT4_PROG" mkfs.ext4
> _require_command "$E2FSCK_PROG" e2fsck
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] fstests: check for ext3 support in btrfs/136
2024-11-11 12:24 [PATCH] fstests: check for ext3 support in btrfs/136 Johannes Thumshirn
2024-11-11 19:45 ` Zorro Lang
@ 2024-11-14 9:56 ` Anand Jain
1 sibling, 0 replies; 3+ messages in thread
From: Anand Jain @ 2024-11-14 9:56 UTC (permalink / raw)
To: Johannes Thumshirn, Zorro Lang; +Cc: fstests, linux-btrfs, Johannes Thumshirn
Reviewed-by: Anand Jain <anand.jain@oracle.com>
On 11/11/24 20:24, Johannes Thumshirn wrote:
> Test-case btrfs/136 requires ext3 support, so check for ext3 using
> _require_extra_fs.
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> ---
> tests/btrfs/136 | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/btrfs/136 b/tests/btrfs/136
> index 9b5b3331119f..2a5280fb9bd1 100755
> --- a/tests/btrfs/136
> +++ b/tests/btrfs/136
> @@ -20,6 +20,8 @@ _require_scratch_nocheck
> # ext4 does not support zoned block device
> _require_non_zoned_device "${SCRATCH_DEV}"
>
> +_require_extra_fs ext3
> +
> _require_command "$BTRFS_CONVERT_PROG" btrfs-convert
> _require_command "$MKFS_EXT4_PROG" mkfs.ext4
> _require_command "$E2FSCK_PROG" e2fsck
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-11-14 9:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-11 12:24 [PATCH] fstests: check for ext3 support in btrfs/136 Johannes Thumshirn
2024-11-11 19:45 ` Zorro Lang
2024-11-14 9:56 ` Anand Jain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox