[syzbot] [gfs2?] general protection fault in gfs2_remove_from_journal (2)

[syzbot] [gfs2?] general protection fault in gfs2_remove_from_journal (2)

[syzbot]

Hello,

syzbot found the following issue on:

HEAD commit:    e811c33b1f13 Merge tag 'drm-fixes-2025-11-08' of https://g..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1609aa92580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=929790bc044e87d7
dashboard link: https://syzkaller.appspot.com/bug?extid=cff8e1b82d7911dd051c
compiler:       Debian clang version 20.1.8 (++20250708063551+0c9f909b7976-1~exp1~20250708183702.136), Debian LLD 20.1.8

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/d900f083ada3/non_bootable_disk-e811c33b.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/9a1852775b7f/vmlinux-e811c33b.xz
kernel image: https://storage.googleapis.com/syzbot-assets/d2f7ca742771/bzImage-e811c33b.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+cff8e1b82d7911dd051c@syzkaller.appspotmail.com

Zero length message leads to an empty skb
Oops: general protection fault, probably for non-canonical address 0xdffffc0000000005: 0000 [#1] SMP KASAN NOPTI
KASAN: null-ptr-deref in range [0x0000000000000028-0x000000000000002f]
CPU: 0 UID: 0 PID: 5331 Comm: syz.0.0 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
RIP: 0010:gfs2_remove_from_journal+0x3cc/0x6d0 fs/gfs2/meta_io.c:359
Code: 3a 4c 89 e7 e8 05 ab 27 fe eb 30 e8 9e 6b c0 fd 48 8b 6c 24 10 4c 8d 65 2c 4c 89 e0 48 c1 e8 03 49 be 00 00 00 00 00 fc ff df <42> 0f b6 04 30 84 c0 4c 8b 3c 24 0f 85 aa 01 00 00 41 ff 04 24 48
RSP: 0018:ffffc9000d4973f8 EFLAGS: 00010207
RAX: 0000000000000005 RBX: ffff88801c0d0000 RCX: 0000000000100000
RDX: ffffc9000e683000 RSI: 0000000000000e73 RDI: 0000000000000e74
RBP: 0000000000000000 R08: ffff8880434e0caf R09: 1ffff1100869c195
R10: dffffc0000000000 R11: ffffed100869c196 R12: 000000000000002c
R13: 0000000000000001 R14: dffffc0000000000 R15: ffff8880511d41e0
FS:  00007fa4cc38a6c0(0000) GS:ffff88808d730000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000200000000140 CR3: 000000004233d000 CR4: 0000000000352ef0
Call Trace:
 <TASK>
 gfs2_discard fs/gfs2/aops.c:597 [inline]
 gfs2_invalidate_folio+0x579/0x750 fs/gfs2/aops.c:631
 folio_invalidate mm/truncate.c:140 [inline]
 truncate_cleanup_folio+0x2d8/0x430 mm/truncate.c:160
 truncate_inode_pages_range+0x233/0xda0 mm/truncate.c:379
 do_gfs2_set_flags fs/gfs2/file.c:254 [inline]
 gfs2_fileattr_set+0x80a/0x9b0 fs/gfs2/file.c:311
 vfs_fileattr_set+0x932/0xb90 fs/file_attr.c:298
 ioctl_setflags+0x180/0x1e0 fs/file_attr.c:334
 do_vfs_ioctl+0x8ed/0x1430 fs/ioctl.c:560
 __do_sys_ioctl fs/ioctl.c:595 [inline]
 __se_sys_ioctl+0x82/0x170 fs/ioctl.c:583
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xfa/0xfa0 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fa4cb58f6c9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fa4cc38a038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007fa4cb7e6090 RCX: 00007fa4cb58f6c9
RDX: 0000200000000140 RSI: 0000000040086602 RDI: 0000000000000005
RBP: 00007fa4cb611f91 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fa4cb7e6128 R14: 00007fa4cb7e6090 R15: 00007ffcd258e628
 </TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:gfs2_remove_from_journal+0x3cc/0x6d0 fs/gfs2/meta_io.c:359
Code: 3a 4c 89 e7 e8 05 ab 27 fe eb 30 e8 9e 6b c0 fd 48 8b 6c 24 10 4c 8d 65 2c 4c 89 e0 48 c1 e8 03 49 be 00 00 00 00 00 fc ff df <42> 0f b6 04 30 84 c0 4c 8b 3c 24 0f 85 aa 01 00 00 41 ff 04 24 48
RSP: 0018:ffffc9000d4973f8 EFLAGS: 00010207
RAX: 0000000000000005 RBX: ffff88801c0d0000 RCX: 0000000000100000
RDX: ffffc9000e683000 RSI: 0000000000000e73 RDI: 0000000000000e74
RBP: 0000000000000000 R08: ffff8880434e0caf R09: 1ffff1100869c195
R10: dffffc0000000000 R11: ffffed100869c196 R12: 000000000000002c
R13: 0000000000000001 R14: dffffc0000000000 R15: ffff8880511d41e0
FS:  00007fa4cc38a6c0(0000) GS:ffff88808d730000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000200000000140 CR3: 000000004233d000 CR4: 0000000000352ef0
----------------
Code disassembly (best guess):
   0:	3a 4c 89 e7          	cmp    -0x19(%rcx,%rcx,4),%cl
   4:	e8 05 ab 27 fe       	call   0xfe27ab0e
   9:	eb 30                	jmp    0x3b
   b:	e8 9e 6b c0 fd       	call   0xfdc06bae
  10:	48 8b 6c 24 10       	mov    0x10(%rsp),%rbp
  15:	4c 8d 65 2c          	lea    0x2c(%rbp),%r12
  19:	4c 89 e0             	mov    %r12,%rax
  1c:	48 c1 e8 03          	shr    $0x3,%rax
  20:	49 be 00 00 00 00 00 	movabs $0xdffffc0000000000,%r14
  27:	fc ff df
* 2a:	42 0f b6 04 30       	movzbl (%rax,%r14,1),%eax <-- trapping instruction
  2f:	84 c0                	test   %al,%al
  31:	4c 8b 3c 24          	mov    (%rsp),%r15
  35:	0f 85 aa 01 00 00    	jne    0x1e5
  3b:	41 ff 04 24          	incl   (%r12)
  3f:	48                   	rex.W


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@googlegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

If the report is already addressed, let syzbot know by replying with:
#syz fix: exact-commit-title

If you want to overwrite report's subsystems, reply with:
#syz set subsystems: new-subsystem
(See the list of subsystem names on the web dashboard)

If the report is a duplicate of another one, reply with:
#syz dup: exact-subject-of-another-report

If you want to undo deduplication, reply with:
#syz undup

Re: [syzbot] [gfs2?] general protection fault in gfs2_remove_from_journal (2)

[syzbot]

syzbot has found a reproducer for the following issue on:

HEAD commit:    fcb70a56f4d8 Merge tag 'vfs-6.19-rc8.fixes' of git://git.k..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=11e3432a580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=4aae00ac5a9d2645
dashboard link: https://syzkaller.appspot.com/bug?extid=cff8e1b82d7911dd051c
compiler:       Debian clang version 21.1.8 (++20251221033036+2078da43e25a-1~exp1~20251221153213.50), Debian LLD 21.1.8
syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=15a87d2a580000
C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=10050988580000

Downloadable assets:
disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/d900f083ada3/non_bootable_disk-fcb70a56.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/d1800162cc24/vmlinux-fcb70a56.xz
kernel image: https://storage.googleapis.com/syzbot-assets/a90ccad4f274/bzImage-fcb70a56.xz
mounted in repro: https://storage.googleapis.com/syzbot-assets/039b62a3a6da/mount_0.gz
  fsck result: failed (log: https://syzkaller.appspot.com/x/fsck.log?x=13cb8c52580000)

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+cff8e1b82d7911dd051c@syzkaller.appspotmail.com

RBP: 00007ffdcb694960 R08: 00007ffdcb695960 R09: 00000000ffffffff
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffdcb6959f0
R13: 00007f9bb640471f R14: 000000000001c700 R15: 00007ffdcb695a30
 </TASK>
Oops: general protection fault, probably for non-canonical address 0xdffffc0000000005: 0000 [#1] SMP KASAN NOPTI
KASAN: null-ptr-deref in range [0x0000000000000028-0x000000000000002f]
CPU: 0 UID: 0 PID: 5454 Comm: syz-executor Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014
RIP: 0010:gfs2_remove_from_journal+0x3bb/0x6b0 fs/gfs2/meta_io.c:356
Code: 3a 4c 89 e7 e8 06 aa 1a fe eb 30 e8 2f d0 b0 fd 48 8b 6c 24 10 4c 8d 65 2c 4c 89 e0 48 c1 e8 03 49 be 00 00 00 00 00 fc ff df <42> 0f b6 04 30 84 c0 4c 8b 3c 24 0f 85 9d 01 00 00 41 ff 04 24 48
RSP: 0018:ffffc900029f7510 EFLAGS: 00010207
RAX: 0000000000000005 RBX: ffff8880476e93a0 RCX: ffff88800094a4c0
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000001
RBP: 0000000000000000 R08: ffff8880121fccff R09: 1ffff1100243f99f
R10: dffffc0000000000 R11: ffffed100243f9a0 R12: 000000000000002c
R13: 0000000000000001 R14: dffffc0000000000 R15: ffff888041d9a170
FS:  000055558f4ef500(0000) GS:ffff88808ccea000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f6bd52346c8 CR3: 00000000455fc000 CR4: 0000000000352ef0
Call Trace:
 <TASK>
 gfs2_discard fs/gfs2/aops.c:593 [inline]
 gfs2_invalidate_folio+0x579/0x750 fs/gfs2/aops.c:627
 folio_invalidate mm/truncate.c:140 [inline]
 truncate_cleanup_folio+0xcb/0x190 mm/truncate.c:160
 truncate_inode_pages_range+0x2ce/0xe30 mm/truncate.c:404
 gfs2_evict_inode+0x324/0x1050 fs/gfs2/super.c:1426
 evict+0x61e/0xb10 fs/inode.c:837
 gfs2_put_super+0x355/0x860 fs/gfs2/super.c:617
 generic_shutdown_super+0x135/0x2c0 fs/super.c:643
 kill_block_super+0x44/0x90 fs/super.c:1722
 deactivate_locked_super+0xbc/0x130 fs/super.c:474
 cleanup_mnt+0x437/0x4d0 fs/namespace.c:1318
 task_work_run+0x1d9/0x270 kernel/task_work.c:233
 resume_user_mode_work include/linux/resume_user_mode.h:50 [inline]
 __exit_to_user_mode_loop kernel/entry/common.c:44 [inline]
 exit_to_user_mode_loop+0xed/0x480 kernel/entry/common.c:75
 __exit_to_user_mode_prepare include/linux/irq-entry-common.h:226 [inline]
 syscall_exit_to_user_mode_prepare include/linux/irq-entry-common.h:256 [inline]
 syscall_exit_to_user_mode_work include/linux/entry-common.h:159 [inline]
 syscall_exit_to_user_mode include/linux/entry-common.h:194 [inline]
 do_syscall_64+0x2b7/0xf80 arch/x86/entry/syscall_64.c:100
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f9bb639c117
Code: a2 c7 05 7c 94 24 00 00 00 00 00 eb 96 e8 e1 12 00 00 90 31 f6 e9 09 00 00 00 66 0f 1f 84 00 00 00 00 00 b8 a6 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 01 c3 48 c7 c2 e8 ff ff ff f7 d8 64 89 02 b8
RSP: 002b:00007ffdcb6948a8 EFLAGS: 00000246 ORIG_RAX: 00000000000000a6
RAX: 0000000000000000 RBX: 00007f9bb640471f RCX: 00007f9bb639c117
RDX: 0000000000000000 RSI: 0000000000000009 RDI: 00007ffdcb694960
RBP: 00007ffdcb694960 R08: 00007ffdcb695960 R09: 00000000ffffffff
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffdcb6959f0
R13: 00007f9bb640471f R14: 000000000001c700 R15: 00007ffdcb695a30
 </TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:gfs2_remove_from_journal+0x3bb/0x6b0 fs/gfs2/meta_io.c:356
Code: 3a 4c 89 e7 e8 06 aa 1a fe eb 30 e8 2f d0 b0 fd 48 8b 6c 24 10 4c 8d 65 2c 4c 89 e0 48 c1 e8 03 49 be 00 00 00 00 00 fc ff df <42> 0f b6 04 30 84 c0 4c 8b 3c 24 0f 85 9d 01 00 00 41 ff 04 24 48
RSP: 0018:ffffc900029f7510 EFLAGS: 00010207
RAX: 0000000000000005 RBX: ffff8880476e93a0 RCX: ffff88800094a4c0
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000001
RBP: 0000000000000000 R08: ffff8880121fccff R09: 1ffff1100243f99f
R10: dffffc0000000000 R11: ffffed100243f9a0 R12: 000000000000002c
R13: 0000000000000001 R14: dffffc0000000000 R15: ffff888041d9a170
FS:  000055558f4ef500(0000) GS:ffff88808ccea000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f6bd52346c8 CR3: 00000000455fc000 CR4: 0000000000352ef0
----------------
Code disassembly (best guess):
   0:	3a 4c 89 e7          	cmp    -0x19(%rcx,%rcx,4),%cl
   4:	e8 06 aa 1a fe       	call   0xfe1aaa0f
   9:	eb 30                	jmp    0x3b
   b:	e8 2f d0 b0 fd       	call   0xfdb0d03f
  10:	48 8b 6c 24 10       	mov    0x10(%rsp),%rbp
  15:	4c 8d 65 2c          	lea    0x2c(%rbp),%r12
  19:	4c 89 e0             	mov    %r12,%rax
  1c:	48 c1 e8 03          	shr    $0x3,%rax
  20:	49 be 00 00 00 00 00 	movabs $0xdffffc0000000000,%r14
  27:	fc ff df
* 2a:	42 0f b6 04 30       	movzbl (%rax,%r14,1),%eax <-- trapping instruction
  2f:	84 c0                	test   %al,%al
  31:	4c 8b 3c 24          	mov    (%rsp),%r15
  35:	0f 85 9d 01 00 00    	jne    0x1d8
  3b:	41 ff 04 24          	incl   (%r12)
  3f:	48                   	rex.W


---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

Re: [syzbot] [gfs2?] general protection fault in gfs2_remove_from_journal (2)

[Qing Wang]

#syz test

diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c
index e4356198d8d8..8c3d0a83cb98 100644
--- a/fs/gfs2/meta_io.c
+++ b/fs/gfs2/meta_io.c
@@ -346,16 +346,16 @@ void gfs2_remove_from_journal(struct buffer_head *bh, int meta)
 	struct gfs2_trans *tr = current->journal_info;
 	int was_pinned = 0;
 
-	if (test_clear_buffer_pinned(bh)) {
-		trace_gfs2_pin(bd, 0);
-		atomic_dec(&sdp->sd_log_pinned);
-		list_del_init(&bd->bd_list);
-		if (meta == REMOVE_META)
-			tr->tr_num_buf_rm++;
-		else
-			tr->tr_num_databuf_rm++;
-		set_bit(TR_TOUCHED, &tr->tr_flags);
-		was_pinned = 1;
+	if (test_clear_buffer_pinned(bh) && bd) {
+			trace_gfs2_pin(bd, 0);
+			atomic_dec(&sdp->sd_log_pinned);
+			list_del_init(&bd->bd_list);
+			if (meta == REMOVE_META)
+				tr->tr_num_buf_rm++;
+			else
+				tr->tr_num_databuf_rm++;
+			set_bit(TR_TOUCHED, &tr->tr_flags);
+			was_pinned = 1;
 		brelse(bh);
 	}
 	if (bd) {

Re: [syzbot] [gfs2?] general protection fault in gfs2_remove_from_journal (2)

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
lost connection to test machine



Tested on:

commit:         cee73b1e Merge tag 'riscv-for-linus-7.0-mw1' of git://..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=115eaf8a580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=df1d67d06552de89
dashboard link: https://syzkaller.appspot.com/bug?extid=cff8e1b82d7911dd051c
compiler:       Debian clang version 21.1.8 (++20251221033036+2078da43e25a-1~exp1~20251221153213.50), Debian LLD 21.1.8
patch:          https://syzkaller.appspot.com/x/patch.diff?x=15e30722580000

Re: [syzbot] [gfs2?] general protection fault in gfs2_remove_from_journal (2)

[Qing Wang]

#syz test

diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c
index e4356198d8d8..3a60a8bd80f7 100644
--- a/fs/gfs2/meta_io.c
+++ b/fs/gfs2/meta_io.c
@@ -349,7 +349,8 @@ void gfs2_remove_from_journal(struct buffer_head *bh, int meta)
 	if (test_clear_buffer_pinned(bh)) {
 		trace_gfs2_pin(bd, 0);
 		atomic_dec(&sdp->sd_log_pinned);
-		list_del_init(&bd->bd_list);
+		if (bd)
+			list_del_init(&bd->bd_list);
 		if (meta == REMOVE_META)
 			tr->tr_num_buf_rm++;
 		else

Re: [syzbot] [gfs2?] general protection fault in gfs2_remove_from_journal (2)

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
lost connection to test machine



Tested on:

commit:         cee73b1e Merge tag 'riscv-for-linus-7.0-mw1' of git://..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=119b0722580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=df1d67d06552de89
dashboard link: https://syzkaller.appspot.com/bug?extid=cff8e1b82d7911dd051c
compiler:       Debian clang version 21.1.8 (++20251221033036+2078da43e25a-1~exp1~20251221153213.50), Debian LLD 21.1.8
patch:          https://syzkaller.appspot.com/x/patch.diff?x=1196e652580000

Re: [syzbot] [gfs2?] general protection fault in gfs2_remove_from_journal (2)

[Qing Wang]

#syz test

diff --git a/fs/gfs2/meta_io.c b/fs/gfs2/meta_io.c
index e4356198d8d8..f459ad89b641 100644
--- a/fs/gfs2/meta_io.c
+++ b/fs/gfs2/meta_io.c
@@ -350,11 +350,13 @@ void gfs2_remove_from_journal(struct buffer_head *bh, int meta)
 		trace_gfs2_pin(bd, 0);
 		atomic_dec(&sdp->sd_log_pinned);
 		list_del_init(&bd->bd_list);
-		if (meta == REMOVE_META)
-			tr->tr_num_buf_rm++;
-		else
-			tr->tr_num_databuf_rm++;
-		set_bit(TR_TOUCHED, &tr->tr_flags);
+		if (tr) {
+			if (meta == REMOVE_META)
+				tr->tr_num_buf_rm++;
+			else
+				tr->tr_num_databuf_rm++;
+			set_bit(TR_TOUCHED, &tr->tr_flags);
+		}
 		was_pinned = 1;
 		brelse(bh);
 	}

Re: [syzbot] [gfs2?] general protection fault in gfs2_remove_from_journal (2)

[syzbot]

Hello,

syzbot has tested the proposed patch but the reproducer is still triggering an issue:
lost connection to test machine



Tested on:

commit:         cee73b1e Merge tag 'riscv-for-linus-7.0-mw1' of git://..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=16dde3b2580000
kernel config:  https://syzkaller.appspot.com/x/.config?x=df1d67d06552de89
dashboard link: https://syzkaller.appspot.com/bug?extid=cff8e1b82d7911dd051c
compiler:       Debian clang version 21.1.8 (++20251221033036+2078da43e25a-1~exp1~20251221153213.50), Debian LLD 21.1.8
patch:          https://syzkaller.appspot.com/x/patch.diff?x=15b0fa52580000