Git development
 help / color / mirror / Atom feed
From: Ophir Bleicher <ophirble@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ophir Bleicher via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH v2] doc: fix AsciiDoc syntax
Date: Fri, 20 Nov 2026 21:25:16 +0200	[thread overview]
Message-ID: <072A2362-2FCF-4DC0-8460-86B63498226E@gmail.com> (raw)
In-Reply-To: <xmqqtslbpbpa.fsf@gitster.g>

OK, thank you!

> On 20 Nov 2026, at 21:03, Junio C Hamano <gitster@pobox.com> wrote:
> 
> "Ophir Bleicher via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> From: Ophir Bleicher <ophirble@gmail.com>
>> 
>> The Documentation/MyFirstContribution.adoc file accidentally used
>> Markdown syntax for a link:
>> 
>> [here](https://gitgitgadget.github.io/#...)
>> 
>> Fixed it to use AsciiDoc:
>> 
>> https://gitgitgadget.github.io/#...[here]
>> 
>> Signed-off-by: Ophir Bleicher <ophirble@gmail.com>
>> ---
> 
> The exact same tense and mood suggestion applies to this commit
> message, too.  "uses" and "Fix".  I can locally tweak them while
> queuing, so no need to resend if you are OK with it.
> 
>>    doc: fix AsciiDoc syntax
>> 
>>    Difference from v1:
>> 
>>     * Change link text
>> 
>> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2496%2FOphirBleicher%2Fpatch-3-v2
>> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2496/OphirBleicher/patch-3-v2
>> Pull-Request: https://github.com/git/git/pull/2496
>> 
>> Range-diff vs v1:
>> 
>> 1:  748ac69283 ! 1:  cf26060e59 doc: fix AsciiDoc syntax
>>     @@ Documentation/MyFirstContribution.adoc: either with the "New pull request" butto
>> 
>>       The differences between using `gitgitgadget/git` and `git/git` as your base can
>>      -be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror)
>>     -+be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[here]
>>     ++be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[on GitGitGadget's official documentation.]
>> 
>>       Review the PR's title and description, as they're used by GitGitGadget
>>       respectively as the subject and body of the cover letter for your change. Refer
>> 
>> 
>> Documentation/MyFirstContribution.adoc | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
>> index c58253fd54..73dab5f7c9 100644
>> --- a/Documentation/MyFirstContribution.adoc
>> +++ b/Documentation/MyFirstContribution.adoc
>> @@ -931,7 +931,7 @@ either with the "New pull request" button or the convenient "Compare & pull
>> request" button that may appear with the name of your newly pushed branch.
>> 
>> The differences between using `gitgitgadget/git` and `git/git` as your base can
>> -be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror)
>> +be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[on GitGitGadget's official documentation.]
>> 
>> Review the PR's title and description, as they're used by GitGitGadget
>> respectively as the subject and body of the cover letter for your change. Refer
>> 
>> base-commit: f7de81456940dd6f3274e461149bba12965de609



      reply	other threads:[~2026-11-20 19:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 17:12 [PATCH] doc: fix AsciiDoc syntax Ophir Bleicher via GitGitGadget
2026-11-20 17:54 ` Ben Knoble
2026-11-20 18:08   ` Junio C Hamano
2026-11-20 18:35 ` [PATCH v2] " Ophir Bleicher via GitGitGadget
2026-11-20 19:03   ` Junio C Hamano
2026-11-20 19:25     ` Ophir Bleicher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=072A2362-2FCF-4DC0-8460-86B63498226E@gmail.com \
    --to=ophirble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox