From: Derrick Stolee <stolee@gmail.com>
To: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] doc: add caveat about turning off commit-graph
Date: Thu, 7 May 2026 14:03:52 -0400 [thread overview]
Message-ID: <0b67df77-b0c8-47dd-ace5-8dd80474bbe6@gmail.com> (raw)
In-Reply-To: <3f0e03e4-f1ca-4010-aacf-72b3ce0aebd1@app.fastmail.com>
On 5/7/2026 10:30 AM, Kristoffer Haugsbakk wrote:
> On Wed, May 6, 2026, at 15:59, Derrick Stolee wrote:
>>> [snip]
>>>
>>> But this isn’t mentioned in the user-facing doc. Let’s mention it on
>>> git-replace(1) and git-commit-graph(1).
>>
>> I like your initiative to present this incompatibility in the
>> user-facing docs.
>>
>>> +CAVEATS
>>> +-------
>>> +
>>> +The existence of replace objects or commit grafts turns off reading or
>>> +writing to the commit-graph. See linkgit:git-replace[1].
>>> +
>> This does seem a little weak. It doesn't really say how this will
>> impact the user. Perhaps we could add something about how performance
>> will likely degrade in this mode?
>>
>> The existence of replace objects or commit grafts turns off reading or
>> writing to the commit-graph, which can cause performance issues. See
>> linkgit:git-replace[1].
>
> Thanks, that’s good. But I think this addition makes sense only on
> git-replace(1). In this (example) git-commit-graph(1) case the whole doc
> already explains what the commit-graph is about.
That's fair. Thanks!
-Stolee
next prev parent reply other threads:[~2026-05-07 18:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 20:45 [PATCH] doc: add caveat about turning off commit-graph kristofferhaugsbakk
2026-05-06 13:59 ` Derrick Stolee
2026-05-07 14:30 ` Kristoffer Haugsbakk
2026-05-07 18:03 ` Derrick Stolee [this message]
2026-05-07 18:20 ` [PATCH v2] " kristofferhaugsbakk
2026-05-07 18:59 ` Derrick Stolee
2026-05-07 19:42 ` [PATCH v3] " kristofferhaugsbakk
2026-05-07 19:56 ` Derrick Stolee
2026-05-07 21:14 ` Kristoffer Haugsbakk
2026-05-11 1:16 ` Junio C Hamano
2026-05-11 8:29 ` Oswald Buddenhagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b67df77-b0c8-47dd-ace5-8dd80474bbe6@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox