From: Derrick Stolee <stolee@gmail.com>
To: kristofferhaugsbakk@fastmail.com, git@vger.kernel.org
Cc: Kristoffer Haugsbakk <code@khaugsbakk.name>
Subject: Re: [PATCH v2] doc: add caveat about turning off commit-graph
Date: Thu, 7 May 2026 14:59:16 -0400 [thread overview]
Message-ID: <913c1338-7745-4229-83fc-cd7a03937d1f@gmail.com> (raw)
In-Reply-To: <V2_caveat_commit-graph.68b@msgid.xyz>
On 5/7/2026 2:20 PM, kristofferhaugsbakk@fastmail.com wrote:
> From: Kristoffer Haugsbakk <code@khaugsbakk.name>
>
> The doc `technical/commit-graph.adoc` says that replace objects and
> commit grafts turn off commit-graph:
>
> Commit grafts and replace objects can change the shape of the commit
> history. The latter can also be enabled/disabled on the fly using
> `--no-replace-objects`. This leads to difficulty storing both possible
> interpretations of a commit id, especially when computing generation
> numbers. The commit-graph will not be read or written when
> replace-objects or grafts are present.
>
> But this isn’t mentioned in the user-facing doc. Let’s mention it on
> git-replace(1) and git-commit-graph(1).
...
> Interdiff against v1:
> diff --git a/Documentation/git-replace.adoc b/Documentation/git-replace.adoc
> index 2c0ea07724d..436a0e58caf 100644
> --- a/Documentation/git-replace.adoc
> +++ b/Documentation/git-replace.adoc
> @@ -149,7 +149,8 @@ CAVEATS
> -------
>
> The existence of replace objects or commit grafts turns off reading or
> -writing to the commit-graph. See linkgit:git-commit-graph[1].
> +writing to the commit-graph, which can cause performance issues. See
> +linkgit:git-commit-graph[1].
Thanks for the update! LGTM.
-Stolee
next prev parent reply other threads:[~2026-05-07 18:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 20:45 [PATCH] doc: add caveat about turning off commit-graph kristofferhaugsbakk
2026-05-06 13:59 ` Derrick Stolee
2026-05-07 14:30 ` Kristoffer Haugsbakk
2026-05-07 18:03 ` Derrick Stolee
2026-05-07 18:20 ` [PATCH v2] " kristofferhaugsbakk
2026-05-07 18:59 ` Derrick Stolee [this message]
2026-05-07 19:42 ` [PATCH v3] " kristofferhaugsbakk
2026-05-07 19:56 ` Derrick Stolee
2026-05-07 21:14 ` Kristoffer Haugsbakk
2026-05-11 1:16 ` Junio C Hamano
2026-05-11 8:29 ` Oswald Buddenhagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=913c1338-7745-4229-83fc-cd7a03937d1f@gmail.com \
--to=stolee@gmail.com \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox