From: Marcel Holtmann <marcel@holtmann.org>
To: Petr Baudis <pasky@ucw.cz>
Cc: Sean <seanlkml@sympatico.ca>, GIT Mailing List <git@vger.kernel.org>
Subject: Re: Commit template
Date: Sun, 08 May 2005 22:36:57 +0200 [thread overview]
Message-ID: <1115584617.8949.51.camel@pegasus> (raw)
In-Reply-To: <20050508201723.GH9495@pasky.ji.cz>
Hi Petr,
> > > my argument is; not to mess up with the CG: lines created by cg-commit.
> > > If you wanna insert a warning then you can of course add additional CG:
> > > lines to the commit template.
> >
> > Well, i'd argue that anyone making their own commit should be responsible
> > for making it look however they like. Maybe they want to only use only 60
> > character wide lines and are tired of seeing the notice about CG: being
> > ignored. Gives the power user a tad more flexibility. But I really
> > don't care much either way.
>
> I'm with Sean on this one - implemented (with current cg-commit, and I
> used .git/commit-template file instead), committed, pushed out.
then please do a "touch .git/commit-template" and call cg-commit. Now
you will see what I mean. It is too easy to screw up.
Why not leave the list of modified files in the hand of the cg-commit
and people that wanna extra text inside their commit-template add
something like:
CG: ---
CG: This is my testing tree, don't commit
This will look much prettier and gives people the same possibilities to
change everything. If you wanna make the modified files list into a full
configurable template, then I think you must introduce place holders.
Also an option to suppress the list of modified files is possible.
Regards
Marcel
next prev parent reply other threads:[~2005-05-08 20:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-08 19:07 Commit template Sean
2005-05-08 19:16 ` Marcel Holtmann
2005-05-08 19:20 ` Sean
2005-05-08 19:30 ` Marcel Holtmann
2005-05-08 19:57 ` Sean
2005-05-08 20:03 ` Marcel Holtmann
2005-05-08 20:06 ` Sean
2005-05-08 20:17 ` Petr Baudis
2005-05-08 20:36 ` Marcel Holtmann [this message]
2005-05-08 20:40 ` Petr Baudis
2005-05-08 21:09 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1115584617.8949.51.camel@pegasus \
--to=marcel@holtmann.org \
--cc=git@vger.kernel.org \
--cc=pasky@ucw.cz \
--cc=seanlkml@sympatico.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox