* [PATCH] contrib/git-svn: handle array values correctly
@ 2006-04-04 0:41 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2006-04-04 0:41 UTC (permalink / raw)
To: Junio C Hamano, git; +Cc: Eric Wong
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
contrib/git-svn/git-svn.perl | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
0511c05c013dc4e6d17832fad043847c35a30c6d
diff --git a/contrib/git-svn/git-svn.perl b/contrib/git-svn/git-svn.perl
index e7fff46..7c44450 100755
--- a/contrib/git-svn/git-svn.perl
+++ b/contrib/git-svn/git-svn.perl
@@ -75,12 +75,11 @@ foreach my $o (keys %opts) {
my $arg = 'git-repo-config';
$arg .= ' --int' if ($o =~ /=i$/);
$arg .= ' --bool' if ($o !~ /=[sfi]$/);
- $arg .= " svn.$key"; # $key only matches [a-z\-], always shell-safe
if (ref $v eq 'ARRAY') {
- chomp(my @tmp = `$arg`);
+ chomp(my @tmp = `$arg --get-all svn.$key`);
@$v = @tmp if @tmp;
} else {
- chomp(my $tmp = `$arg`);
+ chomp(my $tmp = `$arg --get svn.$key`);
if ($tmp && !($arg =~ / --bool / && $tmp eq 'false')) {
$$v = $tmp;
}
--
1.3.0.rc1.gd3ce-dirty
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2006-04-04 0:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-04-04 0:41 [PATCH] contrib/git-svn: handle array values correctly Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox