* [PATCH 1/2] git-svn: avoid printing filenames of files we're not tracking
@ 2006-11-05 5:51 Eric Wong
2006-11-05 5:51 ` [PATCH 2/2] git-svn: don't die on rebuild when --upgrade is specified Eric Wong
0 siblings, 1 reply; 2+ messages in thread
From: Eric Wong @ 2006-11-05 5:51 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Eric Wong
This is purely an aesthetic change, we already skip importing of
files that don't affect the subdirectory we import.
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
git-svn.perl | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index 37ecc51..cc3335a 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -2662,11 +2662,12 @@ sub libsvn_connect {
}
sub libsvn_get_file {
- my ($gui, $f, $rev) = @_;
+ my ($gui, $f, $rev, $chg) = @_;
my $p = $f;
if (length $SVN_PATH > 0) {
return unless ($p =~ s#^\Q$SVN_PATH\E/##);
}
+ print "\t$chg\t$f\n" unless $_q;
my ($hash, $pid, $in, $out);
my $pool = SVN::Pool->new;
@@ -2769,8 +2770,7 @@ sub libsvn_fetch {
$pool->clear;
}
foreach (@amr) {
- print "\t$_->[0]\t$_->[1]\n" unless $_q;
- libsvn_get_file($gui, $_->[1], $rev)
+ libsvn_get_file($gui, $_->[1], $rev, $_->[0]);
}
close $gui or croak $?;
return libsvn_log_entry($rev, $author, $date, $msg, [$last_commit]);
@@ -2848,8 +2848,7 @@ sub libsvn_traverse {
if (defined $files) {
push @$files, $file;
} else {
- print "\tA\t$file\n" unless $_q;
- libsvn_get_file($gui, $file, $rev);
+ libsvn_get_file($gui, $file, $rev, 'A');
}
}
}
--
1.4.3.3.ga126
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH 2/2] git-svn: don't die on rebuild when --upgrade is specified
2006-11-05 5:51 [PATCH 1/2] git-svn: avoid printing filenames of files we're not tracking Eric Wong
@ 2006-11-05 5:51 ` Eric Wong
0 siblings, 0 replies; 2+ messages in thread
From: Eric Wong @ 2006-11-05 5:51 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Eric Wong
--copy-remote and --upgrade are rarely (never?) used together,
so if --copy-remote is specified, that means the user really
wanted to copy the remote ref, and we should fail if that fails.
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
git-svn.perl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-svn.perl b/git-svn.perl
index cc3335a..4a56f18 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -3139,7 +3139,7 @@ sub copy_remote_ref {
my $ref = "refs/remotes/$GIT_SVN";
if (safe_qx('git-ls-remote', $origin, $ref)) {
sys(qw/git fetch/, $origin, "$ref:$ref");
- } else {
+ } elsif ($_cp_remote && !$_upgrade) {
die "Unable to find remote reference: ",
"refs/remotes/$GIT_SVN on $origin\n";
}
--
1.4.3.3.ga126
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-05 5:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-05 5:51 [PATCH 1/2] git-svn: avoid printing filenames of files we're not tracking Eric Wong
2006-11-05 5:51 ` [PATCH 2/2] git-svn: don't die on rebuild when --upgrade is specified Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox