Bug in diff header generation

Bug in diff header generation

[Matthias Kestenholz]

Hello,

I've encountered a small error in the diff header generation when
diffing against files which are not tracked by git:


[13:49] mk@crap ~/Projects/git > git diff git.c ~/bin/viname|head
diff --git a/git.c b/home/mk/bin/viname
old mode 100644
new mode 100755
index 008e016..b64857e
--- a/git.c
+++ b/home/mk/bin/viname
@@ -1,416 +1,106 @@
-#include "builtin.h"
-#include "exec_cmd.h"
-#include "cache.h"
[13:49] mk@crap ~/Projects/git > git diff HEAD:git.c ~/bin/viname|head
diff --git a/home/mk/bin/viname b/home/mk/bin/viname
index 008e016..b64857e 100755
--- a/home/mk/bin/viname
+++ b/home/mk/bin/viname
@@ -1,416 +1,106 @@
-#include "builtin.h"
-#include "exec_cmd.h"
-#include "cache.h"
-#include "quote.h"
-


When a revision is specified, git-diff prints a/home/mk/bin/viname
instead of a/git.c

Because of my final exams I've got no time to look into it right now.


Matthias

Re: Bug in diff header generation

[Johannes Schindelin]

Hi,

On Fri, 2 Mar 2007, Matthias Kestenholz wrote:

> [13:49] mk@crap ~/Projects/git > git diff HEAD:git.c ~/bin/viname|head
> diff --git a/home/mk/bin/viname b/home/mk/bin/viname

This is intended behaviour. You don't want a Git object name as a file 
specifier, because you cannot edit a Git object.

Hth,
Dscho