Git development
 help / color / mirror / Atom feed
* [TopGit PATCH] put die() messages to stderr
@ 2008-11-21 10:05 Bert Wesarg
  2008-11-21 12:36 ` martin f krafft
  0 siblings, 1 reply; 4+ messages in thread
From: Bert Wesarg @ 2008-11-21 10:05 UTC (permalink / raw)
  To: Petr Baudis, Petr Baudis; +Cc: Bert Wesarg, git

Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>

---
 tg.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/tg.sh b/tg.sh
index 4dcc15e..21294f9 100644
--- a/tg.sh
+++ b/tg.sh
@@ -13,7 +13,7 @@ info()
 
 die()
 {
-	info "fatal: $*"
+	info "fatal: $*" >&2
 	exit 1
 }
 
-- 
tg: (f17218e..) bw/die-to-stderr (depends on: master)

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [TopGit PATCH] put die() messages to stderr
  2008-11-21 10:05 [TopGit PATCH] put die() messages to stderr Bert Wesarg
@ 2008-11-21 12:36 ` martin f krafft
  2008-11-21 13:28   ` Marc Weber
  0 siblings, 1 reply; 4+ messages in thread
From: martin f krafft @ 2008-11-21 12:36 UTC (permalink / raw)
  To: Bert Wesarg, Petr Baudis, git

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

also sprach Bert Wesarg <bert.wesarg@googlemail.com> [2008.11.21.1105 +0100]:
> -	info "fatal: $*"
> +	info "fatal: $*" >&2

Shouldn't info also output to stderr?

-- 
martin | http://madduck.net/ | http://two.sentenc.es/
 
"i have made good judgments in the past.
 i have made good judgments in the future."
                                                      - george w. bush
 
spamtraps: madduck.bogus@madduck.net

[-- Attachment #2: Digital signature (see http://martin-krafft.net/gpg/) --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [TopGit PATCH] put die() messages to stderr
  2008-11-21 12:36 ` martin f krafft
@ 2008-11-21 13:28   ` Marc Weber
  2008-11-21 13:56     ` martin f krafft
  0 siblings, 1 reply; 4+ messages in thread
From: Marc Weber @ 2008-11-21 13:28 UTC (permalink / raw)
  To: git

On Fri, Nov 21, 2008 at 01:36:54PM +0100, martin f krafft wrote:
> also sprach Bert Wesarg <bert.wesarg@googlemail.com> [2008.11.21.1105 +0100]:
> > -	info "fatal: $*"
> > +	info "fatal: $*" >&2
> 
> Shouldn't info also output to stderr?

die is calling info. So this patch is enough.

You should just send this patch to the author. I think he'll apply it
instantly. I've send a small patch to him yesterday as well.

Marc Weber

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [TopGit PATCH] put die() messages to stderr
  2008-11-21 13:28   ` Marc Weber
@ 2008-11-21 13:56     ` martin f krafft
  0 siblings, 0 replies; 4+ messages in thread
From: martin f krafft @ 2008-11-21 13:56 UTC (permalink / raw)
  To: Marc Weber, git

[-- Attachment #1: Type: text/plain, Size: 863 bytes --]

also sprach Marc Weber <marco-oweber@gmx.de> [2008.11.21.1428 +0100]:
> > Shouldn't info also output to stderr?
> 
> die is calling info. So this patch is enough.

Sure, I was just wondering whether info() shouldn't also print to
stderr. Or only die(). I think info() prints status messages, which
are not standard operation and thus don't go to stdout, but go to
stderr. No?

> You should just send this patch to the author. I think he'll apply
> it instantly. I've send a small patch to him yesterday as well.

Yes, but I applied that. :)

(I am Petr's apprentice, learning to help him a bit with TopGit).

-- 
martin | http://madduck.net/ | http://two.sentenc.es/
 
"wovon man nicht sprechen kann, darüber muß man schweigen."
                                                       -- wittgenstein
 
spamtraps: madduck.bogus@madduck.net

[-- Attachment #2: Digital signature (see http://martin-krafft.net/gpg/) --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-11-21 13:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-21 10:05 [TopGit PATCH] put die() messages to stderr Bert Wesarg
2008-11-21 12:36 ` martin f krafft
2008-11-21 13:28   ` Marc Weber
2008-11-21 13:56     ` martin f krafft

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox