* [PATCH] color: set color.ui to auto by default
@ 2013-05-16 13:04 Ramkumar Ramachandra
2013-05-16 13:25 ` Matthieu Moy
0 siblings, 1 reply; 3+ messages in thread
From: Ramkumar Ramachandra @ 2013-05-16 13:04 UTC (permalink / raw)
To: Git List; +Cc: Jeff King, Junio C Hamano
This is a good default. Users who don't want color can look for "color"
in the git-config(1), and turn it off.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
---
color.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/color.c b/color.c
index e8e2681..f672885 100644
--- a/color.c
+++ b/color.c
@@ -1,7 +1,7 @@
#include "cache.h"
#include "color.h"
-static int git_use_color_default = 0;
+static int git_use_color_default = GIT_COLOR_AUTO;
int color_stdout_is_tty = -1;
/*
--
1.8.3.rc2.10.g0c2b1cf.dirty
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] color: set color.ui to auto by default
2013-05-16 13:04 [PATCH] color: set color.ui to auto by default Ramkumar Ramachandra
@ 2013-05-16 13:25 ` Matthieu Moy
2013-05-16 13:37 ` Ramkumar Ramachandra
0 siblings, 1 reply; 3+ messages in thread
From: Matthieu Moy @ 2013-05-16 13:25 UTC (permalink / raw)
To: Ramkumar Ramachandra; +Cc: Git List, Jeff King, Junio C Hamano
Ramkumar Ramachandra <artagnon@gmail.com> writes:
> This is a good default. Users who don't want color can look for "color"
> in the git-config(1), and turn it off.
Err, you're comming a bit late ;-). See my patch, posted yesterday, for
the same topic.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] color: set color.ui to auto by default
2013-05-16 13:25 ` Matthieu Moy
@ 2013-05-16 13:37 ` Ramkumar Ramachandra
0 siblings, 0 replies; 3+ messages in thread
From: Ramkumar Ramachandra @ 2013-05-16 13:37 UTC (permalink / raw)
To: Matthieu Moy; +Cc: Git List, Jeff King, Junio C Hamano
Matthieu Moy wrote:
> Err, you're comming a bit late ;-). See my patch, posted yesterday, for
> the same topic.
Ah, too much email :|
Your patch looks good.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-16 13:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-16 13:04 [PATCH] color: set color.ui to auto by default Ramkumar Ramachandra
2013-05-16 13:25 ` Matthieu Moy
2013-05-16 13:37 ` Ramkumar Ramachandra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox