Git development
 help / color / mirror / Atom feed
From: "Rhodes, Kate" <masukomi@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [Bug?] uncommited changes cross branches
Date: Tue, 5 Feb 2008 15:34:09 -0500	[thread overview]
Message-ID: <140813C2-123F-48CB-99CC-4E9A9B6C33B9@gmail.com> (raw)
In-Reply-To: <alpine.LSU.1.00.0802051502360.8543@racer.site>


On Feb 5, 2008, at 10:07 AM, Johannes Schindelin wrote:

> Hi,
>
> On Tue, 5 Feb 2008, Rhodes, Kate wrote:
>
>> If you have a file that exists in two branches in the same repo,  
>> make a
>> change to it without committing, then switch branches the changes  
>> carry
>> over, but if you make changes to a file that exists in only one of  
>> the
>> repos and try and switch branches Git complains that the file isn't
>> uptodate.  The latter behavior seems correct to me.
>
> It is slightly different: if you change a file without committing _- 
> and-
> the switch to another branch does not touch the file, git does not
> complain.
>
> The rationale: git should refuse to switch branches _only_ if  
> uncommitted
> changes would be lost.
>
> However, if you change a file whose content is different in the other
> branch (and "not existing" qualifies), the uncommitted changes would  
> be
> lost, and git should complain.

That makes sense, but I wonder if the distinction isn't a little too  
subtle for most users to pick up on without being told, and if letting  
uncommitted changes cross branches without some explicit user approval  
is a good idea. I assume that once someone becomes really used to  
working with multiple branches within the same repo you'd build up  
subconscious safeguards against accidentally pulling changes into a  
branch you didn't mean to, but I worry that it's going to be  
problematic for users starting out with git.

To me it's like the difference between -d and -D in git-branch. It's  
generally a good idea to use -d by default and have git warn you that  
you're about to do something that could screw you up.

-kate == masukomi

      reply	other threads:[~2008-02-05 20:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 14:45 [Bug?] uncommited changes cross branches Rhodes, Kate
2008-02-05 15:07 ` Johannes Schindelin
2008-02-05 20:34   ` Rhodes, Kate [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=140813C2-123F-48CB-99CC-4E9A9B6C33B9@gmail.com \
    --to=masukomi@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox