Git development
 help / color / mirror / Atom feed
From: "Rhodes, Kate" <masukomi@gmail.com>
To: git@vger.kernel.org
Subject: [Bug?] uncommited changes cross branches
Date: Tue, 5 Feb 2008 09:45:30 -0500	[thread overview]
Message-ID: <CB070331-8CA6-42CD-9CAD-20371F16DCD8@gmail.com> (raw)

If you have a file that exists in two branches in the same repo, make  
a change to it without committing, then switch branches the changes  
carry over, but if you make changes to a file that exists in only one  
of the repos and try and switch branches Git complains that the file  
isn't uptodate.  The latter behavior seems correct to me.

Changes I make in any branch should not just follow me around as I  
switch through other branches. It seems not only conceptually broken  
to me, but also something that make it very easy to accidentally  
commit changes to an unintended branch if you weren't paying close  
attention when you switched. I think that the appropriate action is to  
not allow a user to switch branches whenever there are files that  
aren't up to date (committing, git-stash, and checkout -m  being the  
obvious, and safe, ways around the blockage).

The documentation *seems* to agree with me and it looks like it was  
the intent of the code to prevent this too, but it obviously doesn't.


In case my description was a little confusing below is a real world  
example of what I'm talking about. The last command is what I believe  
should not be possible:

$ temp krhodes$ mkdir foo
$ temp krhodes$ cd foo/
$ foo krhodes$ git --version
git version 1.5.4.2.g41ac4
$ foo krhodes$ git init
Initialized empty Git repository in .git/
$ foo krhodes$ echo "foo" > foo.txt
$ foo krhodes$ git add foo.txt
$ foo krhodes$ git commit -a -m " initial commit"
Created initial commit 10d7a21:  initial commit
  1 files changed, 1 insertions(+), 0 deletions(-)
  create mode 100644 foo.txt
$ foo krhodes$ git checkout -b branch_one
Switched to a new branch "branch_one"
$ foo krhodes$ echo "bar" > bar.txt
$ foo krhodes$ git add bar.txt
$ foo krhodes$ git commit -a -m "initial branch_one_commit"
Created commit 3251c16: initial branch_one_commit
  1 files changed, 1 insertions(+), 0 deletions(-)
  create mode 100644 bar.txt
$ foo krhodes$ echo "baz" > bar.txt
$ foo krhodes$ git checkout master
fatal: Entry 'bar.txt' not uptodate. Cannot merge.
$ foo krhodes$ git checkout bar.txt
$ foo krhodes$ git checkout master
Switched to branch "master"
$ foo krhodes$ echo "baz" > foo.txt
$ foo krhodes$ git checkout branch_one
M	foo.txt
Switched to branch "branch_one"

-------
-masukomi

             reply	other threads:[~2008-02-05 14:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 14:45 Rhodes, Kate [this message]
2008-02-05 15:07 ` [Bug?] uncommited changes cross branches Johannes Schindelin
2008-02-05 20:34   ` Rhodes, Kate

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CB070331-8CA6-42CD-9CAD-20371F16DCD8@gmail.com \
    --to=masukomi@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox