From: Jon Seymour <jon.seymour@gmail.com>
To: git@vger.kernel.org
Cc: torvalds@osdl.org, jon.seymour@gmail.com
Subject: [PATCH 2/2] Change to gitk to make it use --topo-order rather than --merge-order
Date: Sat, 02 Jul 2005 16:09:38 +1000 [thread overview]
Message-ID: <20050702060938.13030.qmail@blackcubes.dyndns.org> (raw)
This patch make gitk use --topo-order rather than --merge-order.
There is no actual advantage in doing this as the git-rev-list
execution times are dwarfed by tcl/tk overheads so the 3-4 time
git-rev-list speedup is effectively invisible. Still, it
does demonstrate the use of the --topo-order flag.
One advantage of this patch would be to allow gitk to be used
in environments that don't have the ssl bignum library available
for some reason.
Signed-off-by: Jon Seymour <jon.seymour@gmail.com>
---
This patch assumes that git has been patched to include support
for --topo-order.
Here's a chance to test merging a gitk patch from git back into
gitk :-)
---
gitk | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
4deb99b73fd6fc8e4995b55e9e23988c8766f509
diff --git a/gitk b/gitk
--- a/gitk
+++ b/gitk
@@ -37,7 +37,7 @@ proc getcommits {rargs} {
set parsed_args $rargs
}
if [catch {
- set commfd [open "|git-rev-list --header --merge-order $parsed_args" r]
+ set commfd [open "|git-rev-list --header --topo-order $parsed_args" r]
} err] {
puts stderr "Error executing git-rev-list: $err"
exit 1
------------
reply other threads:[~2005-07-02 6:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050702060938.13030.qmail@blackcubes.dyndns.org \
--to=jon.seymour@gmail.com \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox