Git development
 help / color / mirror / Atom feed
* [PATCH 2/2] Change to gitk to make it use --topo-order rather than --merge-order
@ 2005-07-02  6:09 Jon Seymour
  0 siblings, 0 replies; only message in thread
From: Jon Seymour @ 2005-07-02  6:09 UTC (permalink / raw)
  To: git; +Cc: torvalds, jon.seymour


This patch make gitk use --topo-order rather than --merge-order.

There is no actual advantage in doing this as the git-rev-list 
execution times are dwarfed by tcl/tk overheads so the 3-4 time
git-rev-list speedup is effectively invisible. Still, it
does demonstrate the use of the --topo-order flag.

One advantage of this patch would be to allow gitk to be used
in environments that don't have the ssl bignum library available
for some reason.

Signed-off-by: Jon Seymour <jon.seymour@gmail.com>
---
This patch assumes that git has been patched to include support
for --topo-order.

Here's a chance to test merging a gitk patch from git back into
gitk :-)
---

 gitk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

4deb99b73fd6fc8e4995b55e9e23988c8766f509
diff --git a/gitk b/gitk
--- a/gitk
+++ b/gitk
@@ -37,7 +37,7 @@ proc getcommits {rargs} {
 	set parsed_args $rargs
     }
     if [catch {
-	set commfd [open "|git-rev-list --header --merge-order $parsed_args" r]
+	set commfd [open "|git-rev-list --header --topo-order $parsed_args" r]
     } err] {
 	puts stderr "Error executing git-rev-list: $err"
 	exit 1
------------

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-07-02  6:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-02  6:09 [PATCH 2/2] Change to gitk to make it use --topo-order rather than --merge-order Jon Seymour

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox