cogito: cannot add dangling symlinks whereas git can

cogito: cannot add dangling symlinks whereas git can

[Gerrit Pape]

forwarded 313596 upstream
quit

Hi, cg-add refuses to add special files such as dangling symlinks while
git can handle them just fine.  Please see http://bugs.debian.org/313596

I'm not sure why cg-add checks files to commit with test -f.

Regards, Gerrit.

---
diff --git a/cg-add b/cg-add
index 33cdc7f..382f8d5 100755
--- a/cg-add
+++ b/cg-add
@@ -61,9 +61,6 @@ for file in "${ARGS[@]}"; do
 			echo "$file is a directory (use cg-add -r?)" >&2
 			error=1
 		fi
-	elif [ ! -f "$absfile" ]; then
-		echo "$file does not exist or is not a regular file" >&2
-		error=1
 	else
 		echo "$file" >>"$TMPFILE"
 	fi

Re: cogito: cannot add dangling symlinks whereas git can

[Petr Baudis]

Dear diary, on Mon, Jan 02, 2006 at 01:15:17PM CET, I got a letter
where Gerrit Pape <pape@smarden.org> said that...
> forwarded 313596 upstream
> quit
> 
> Hi, cg-add refuses to add special files such as dangling symlinks while
> git can handle them just fine.  Please see http://bugs.debian.org/313596
> 
> I'm not sure why cg-add checks files to commit with test -f.

Because you really do not want to add character specials or named pipes.
;-) I have changed the test to also check for symlinks.

Thanks,

-- 
				Petr "Pasky" Baudis
Stuff: http://pasky.or.cz/
Of the 3 great composers Mozart tells us what it's like to be human,
Beethoven tells us what it's like to be Beethoven and Bach tells us
what it's like to be the universe.  -- Douglas Adams