From: sean <seanlkml@sympatico.ca>
To: Ryan Anderson <ryan@michonline.com>
Cc: git <git@vger.kernel.org>
Subject: annotate.perl triggers rpm bug
Date: Fri, 10 Mar 2006 16:23:20 -0500 [thread overview]
Message-ID: <BAYC1-PASMTP0815EFABBF5266FB641C65AEED0@CEZ.ICE> (raw)
Message-ID: <20060310162320.0a98352b.seanlkml@sympatico.ca> (raw)
Hi Ryan
Commit 87475f4 exposes a problem in the creation of rpms (at least
on Fedora boxes). RPM automatically creates a dependency for any
perl "use" lines, and the above commit fools it into creating a false
dependecy for the nonexistent perl package "revs" because of this
portion of the diff:
+ -S, --rev-file revs-file
+ use revs from revs-file instead of calling git-rev-list
^^ fools rpm
Obviously this creates a problem when someone goes to install the git-core
rpm. Any chance we could get a small change to work around this bug in rpm?
Thanks,
Sean
diff --git a/git-annotate.perl b/git-annotate.perl
index feea0a2..6805b8b 100755
--- a/git-annotate.perl
+++ b/git-annotate.perl
@@ -20,7 +20,7 @@ sub usage() {
-r, --rename
Follow renames (Defaults on).
-S, --rev-file revs-file
- use revs from revs-file instead of calling git-rev-list
+ uses revs from revs-file instead of calling git-rev-list
-h, --help
This message.
';
next reply other threads:[~2006-03-10 21:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060310162320.0a98352b.seanlkml@sympatico.ca>
2006-03-10 21:23 ` sean [this message]
2006-03-11 7:11 ` annotate.perl triggers rpm bug Junio C Hamano
[not found] ` <20060311023928.538097fd.seanlkml@sympatico.ca>
2006-03-11 7:39 ` sean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BAYC1-PASMTP0815EFABBF5266FB641C65AEED0@CEZ.ICE \
--to=seanlkml@sympatico.ca \
--cc=git@vger.kernel.org \
--cc=ryan@michonline.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox