* [PATCH] Add missing semicolon to sed command.
@ 2006-03-20 0:18 Shawn Pearce
2006-03-20 2:15 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Shawn Pearce @ 2006-03-20 0:18 UTC (permalink / raw)
To: git
generate-cmdlist.sh is giving errors messages from sed on Mac OS
10.4 due to a missing semicolon.
---
generate-cmdlist.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
base f81e7c626f34658289594386b0273755f47912a2
last 09913c10d93adbfa61138b7ac7ae6a8a210aa29f
diff --git a/generate-cmdlist.sh b/generate-cmdlist.sh
index 6ee85d5..76ba49c 100755
--- a/generate-cmdlist.sh
+++ b/generate-cmdlist.sh
@@ -42,7 +42,7 @@ EOF
while read cmd
do
sed -n "/NAME/,/git-$cmd/H;
- \$ {x; s/.*git-$cmd - \\(.*\\)/ {\"$cmd\", \"\1\"},/; p}" \
+ \$ {x; s/.*git-$cmd - \\(.*\\)/ {\"$cmd\", \"\1\"},/; p;}" \
"Documentation/git-$cmd.txt"
done
echo "};"
--
1.2.4.g41f6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Add missing semicolon to sed command.
2006-03-20 0:18 [PATCH] Add missing semicolon to sed command Shawn Pearce
@ 2006-03-20 2:15 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2006-03-20 2:15 UTC (permalink / raw)
To: Shawn Pearce; +Cc: git
Shawn Pearce <spearce@spearce.org> writes:
> generate-cmdlist.sh is giving errors messages from sed on Mac OS
> 10.4 due to a missing semicolon.
I'll take this patch for now, but I've heard a horror story that
some other vintage of sed apparently does not like multiple
commands separated by semicolons at all, and I've been training
myself to do this kind of thing always as multi-line sed script,
like this:
sed -n '
/NAME/,/git-'"$cmd"'/H
${
x
s/.*git-'"$cmd"' - \(.*\)/ {"'"$cmd"'", "\1"},/
p
}' "Documentation/git-$cmd.txt"
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-03-20 2:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-03-20 0:18 [PATCH] Add missing semicolon to sed command Shawn Pearce
2006-03-20 2:15 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox