From: Shawn Pearce <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Make '@' not valid in a ref name.
Date: Sat, 20 May 2006 21:58:49 -0400 [thread overview]
Message-ID: <20060521015849.GB7605@spearce.org> (raw)
In-Reply-To: <7vodxsywzk.fsf@assigned-by-dhcp.cox.net>
Junio C Hamano <junkio@cox.net> wrote:
> I am not a fan of retroactively disallowing what we used to
> allow. Is this unavoidable?
>
We're talking about it on #git right now. Someone actually uses
refs like 'user@host/foo' and thus doesn't like this patch either.
We were talking about disallowing '@{' instead. Really its just
'@{<some run that smells like a date}' at the end of the ref which
would want to be disallowed; similiar to how ~ and ^ really only
need to be disallowed near the end.
The date parser grabs '@{' not '@' so 'user@host/foo@{yesterday}'
makes sense to it. But 'user@{host}/foo@{yesterday}' is going
to cause problems as the date parser will attempt to evaluate
'host}/foo@{yesterday'. :-(
--
Shawn.
next prev parent reply other threads:[~2006-05-21 1:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-21 1:37 [PATCH] Make '@' not valid in a ref name Shawn Pearce
2006-05-21 1:42 ` Junio C Hamano
2006-05-21 1:58 ` Shawn Pearce [this message]
2006-05-21 2:00 ` Eric Wong
2006-05-21 2:19 ` Shawn Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060521015849.GB7605@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox