commit triggers.

commit triggers.

[Dave Jones]

I've grepped around, and come up with nothing, so hopefully
I'm not overlooking some already-implemented feature
(though it'd be great if I am).  How much work is involved in
creating a mechanism where some scripts living in say .git/triggers/
get executed on commits ?

The idea behind this stems from some scripts I've been running
periodically against an mbox of the daily kernel commits, which
greps for common bugs; kmalloc(GFP, size) instead of kmalloc(size,GFP),
memsets with reversed 2nd/3rd args etc etc.

It'd be useful I think to have a way to hook up such a script
to git's commit process that aborts a commit if a script returns
a hit, forcing the user to fix up the mistake before committing
it to the world.

thoughts ?

		Dave

-- 
http://www.codemonkey.org.uk

Re: commit triggers.

[Junio C Hamano]

Dave Jones <davej@redhat.com> writes:

> I've grepped around, and come up with nothing, so hopefully
> I'm not overlooking some already-implemented feature
> (though it'd be great if I am).  How much work is involved in
> creating a mechanism where some scripts living in say .git/triggers/
> get executed on commits ?

Perhaps "grep hooks/ git-commit.sh"?

The hooks we have right now are more interested in preventing
you from making crappy commits, so we might not have a
post-commit hook you can use for notification purposes, but if
that is the case I am open to suggestions to add one.  I think
post-commit hook is already there, though.