From: Matthew Wilcox <matthew@wil.cx>
To: git@vger.kernel.org
Subject: [PATCH] Understand the meaning of commas in git-send-email
Date: Tue, 10 Oct 2006 08:59:36 -0600 [thread overview]
Message-ID: <20061010145936.GC8993@parisc-linux.org> (raw)
I made the mistake of adding one Cc: line with two email addresses on
it, instead of two Cc: lines with one email address each. Extending
git-send-email to parse that case turns out to not be too much work.
Signed-off-by: Matthew Wilcox <matthew@wil.cx>
--- /usr/bin/git-send-email 2006-07-29 09:52:13.000000000 -0600
+++ ./git-send-email.perl 2006-10-10 08:46:13.000000000 -0600
@@ -537,13 +542,15 @@
my @emails;
foreach my $entry (@_) {
- if (my $clean = extract_valid_address($entry)) {
- $seen{$clean} ||= 0;
- next if $seen{$clean}++;
- push @emails, $entry;
- } else {
- print STDERR "W: unable to extract a valid address",
- " from: $entry\n";
+ foreach my $addr (split(/, */, $entry)) {
+ if (my $clean = extract_valid_address($addr)) {
+ $seen{$clean} ||= 0;
+ next if $seen{$clean}++;
+ push @emails, $addr;
+ } else {
+ print STDERR "W: unable to extract a valid",
+ " address from: $entry\n";
+ }
}
}
return @emails;
next reply other threads:[~2006-10-10 14:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-10 14:59 Matthew Wilcox [this message]
2006-10-10 17:44 ` [PATCH] Understand the meaning of commas in git-send-email Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061010145936.GC8993@parisc-linux.org \
--to=matthew@wil.cx \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox