Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Matthew Wilcox <matthew@wil.cx>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Understand the meaning of commas in git-send-email
Date: Tue, 10 Oct 2006 10:44:56 -0700	[thread overview]
Message-ID: <7vzmc412w7.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 20061010145936.GC8993@parisc-linux.org

Matthew Wilcox <matthew@wil.cx> writes:

> I made the mistake of adding one Cc: line with two email addresses on
> it, instead of two Cc: lines with one email address each.  Extending
> git-send-email to parse that case turns out to not be too much work.
>
> Signed-off-by: Matthew Wilcox <matthew@wil.cx>

I am not sure.  The input addresses this part of the code deals
with are of human readable form 

	Matthew Wilcox <matthew@wil.cx>
        matthew@wil.cx (Matthew Wilcox)

and the loop is extracting the part inside <> pair.

I have a mild suspicion that your patch may need to understand
quoting to handle somebody else's name safely and correctly.

	junkio@cox.net (Junio C Hamano, aka gitster)

      reply	other threads:[~2006-10-10 17:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-10 14:59 [PATCH] Understand the meaning of commas in git-send-email Matthew Wilcox
2006-10-10 17:44 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vzmc412w7.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox