[PATCH] no need to install manpages as executable

Git development
 help / color / mirror / Atom feed

* [PATCH] no need to install manpages as executable
@ 2006-12-11  7:39 Chris Wright
  2006-12-12  1:15 ` Junio C Hamano
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Wright @ 2006-12-11  7:39 UTC (permalink / raw)
  To: Junio C Hamano; +Cc: git

No need to install manpages as executable.  Noticed by Ville Skyttä.

Signed-off-by: Chris Wright <chrisw@sous-sol.org>
---
Applies cleanly to maint and master.

 Documentation/Makefile |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/Makefile b/Documentation/Makefile
index c00f5f6..d68bc4a 100644
--- a/Documentation/Makefile
+++ b/Documentation/Makefile
@@ -56,8 +56,8 @@ man7: $(DOC_MAN7)
 
 install: man
 	$(INSTALL) -d -m755 $(DESTDIR)$(man1dir) $(DESTDIR)$(man7dir)
-	$(INSTALL) $(DOC_MAN1) $(DESTDIR)$(man1dir)
-	$(INSTALL) $(DOC_MAN7) $(DESTDIR)$(man7dir)
+	$(INSTALL) -m644 $(DOC_MAN1) $(DESTDIR)$(man1dir)
+	$(INSTALL) -m644 $(DOC_MAN7) $(DESTDIR)$(man7dir)
 
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] no need to install manpages as executable
  2006-12-11  7:39 [PATCH] no need to install manpages as executable Chris Wright
@ 2006-12-12  1:15 ` Junio C Hamano
  0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2006-12-12  1:15 UTC (permalink / raw)
  To: Chris Wright; +Cc: git

Chris Wright <chrisw@sous-sol.org> writes:

> No need to install manpages as executable.  Noticed by Ville Skyttä.

Thanks.  I agree there is no need but I wonder why we even need
to specify that explicitly.  Well, I guess I did not know that
install(1) was that stupid.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-12-12  1:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-11  7:39 [PATCH] no need to install manpages as executable Chris Wright
2006-12-12  1:15 ` Junio C Hamano

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox