Git development
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Bill Lear <rael@zopyra.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Junio C Hamano <junkio@cox.net>,
	git@vger.kernel.org
Subject: Re: [PATCH] diff --check: use colour
Date: Thu, 25 Jan 2007 23:31:20 -0500	[thread overview]
Message-ID: <20070126043120.GA6111@coredump.intra.peff.net> (raw)
In-Reply-To: <17849.17947.645022.282882@lisa.zopyra.com>

On Thu, Jan 25, 2007 at 06:06:51PM -0600, Bill Lear wrote:

> >The easiest way to find out what it does is to execute:
> >	git log -S--check diff.c
> 
> Hmm, using 1.5.0-rc2, I created a test repo, and did this:

I think you misunderstood Johannes. The -S option is used to find
revisions that include the given string in their changes. So he was
suggesting running that command in the _git_ repository, to show you the
commit that introduced the --check option (from which you would get some
material for writing the docs...)

> echo foo > foo
> git add foo
> git commit -a -m foo
> echo bar > foo
> git commit -a -m bar
> git log -S--check foo
> 
> and nothing happened.

Right. You never put the word --check into your repository content. :)

> git log -S --check foo
> 
> and the thing went off into outer space.  Now at over 2 1/2 minutes of
> CPU time on my 2 Ghz Opteron box...

This appears to be a bug. I will look into it.

-Peff

  reply	other threads:[~2007-01-26  4:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-24 14:05 [PATCH] diff --check: use colour Johannes Schindelin
2007-01-24 23:18 ` Junio C Hamano
2007-01-25  9:16   ` Johannes Schindelin
2007-01-25 22:23     ` Junio C Hamano
2007-01-25 22:49       ` Bill Lear
2007-01-25 23:41         ` Johannes Schindelin
2007-01-26  0:06           ` Bill Lear
2007-01-26  4:31             ` Jeff King [this message]
2007-01-26 11:10             ` Andreas Ericsson
2007-01-26 12:05             ` Andy Parkins
2007-01-26 13:52               ` Bill Lear
2007-01-26 15:49           ` Bill Lear
2007-01-26 16:00             ` J. Bruce Fields
2007-01-26 16:07               ` Bill Lear
2007-01-26 16:06             ` Bill Lear
2007-01-26 17:19               ` Jeff King
2007-01-26 17:26               ` Jakub Narebski
2007-01-26 16:37             ` Andy Parkins
2007-01-26 17:41               ` Jakub Narebski
2007-01-26  0:17 ` Junio C Hamano
2007-01-26 21:15   ` Johannes Schindelin
2007-02-18  0:25     ` Junio C Hamano
2007-02-18  0:47       ` Johannes Schindelin
2007-02-18  1:06         ` Junio C Hamano
2007-02-18  1:15           ` Johannes Schindelin
2007-02-18 16:27             ` [PATCH for "master"] " Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070126043120.GA6111@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    --cc=rael@zopyra.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox