From: Junio C Hamano <junkio@cox.net>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, junkio@cox.net
Subject: Re: [PATCH] diff --check: use colour
Date: Wed, 24 Jan 2007 15:18:33 -0800 [thread overview]
Message-ID: <7vr6tkdnee.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.63.0701241505260.22628@wbgn013.biozentrum.uni-wuerzburg.de> (Johannes Schindelin's message of "Wed, 24 Jan 2007 15:05:48 +0100 (CET)")
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Reuse the colour handling of the regular diff.
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> Reuse the colour handling of the regular diff.
>
> Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
> ---
>
> Is it possible that diff_get_color() _never_ returns NULL?
> Then diff.c can be further cleaned up...
Does anybody actually use "diff --check"? We could lose more
code by removing the option altogether ;-)
Seriously, this option needs to be documented. Volunteers?
next prev parent reply other threads:[~2007-01-24 23:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-24 14:05 [PATCH] diff --check: use colour Johannes Schindelin
2007-01-24 23:18 ` Junio C Hamano [this message]
2007-01-25 9:16 ` Johannes Schindelin
2007-01-25 22:23 ` Junio C Hamano
2007-01-25 22:49 ` Bill Lear
2007-01-25 23:41 ` Johannes Schindelin
2007-01-26 0:06 ` Bill Lear
2007-01-26 4:31 ` Jeff King
2007-01-26 11:10 ` Andreas Ericsson
2007-01-26 12:05 ` Andy Parkins
2007-01-26 13:52 ` Bill Lear
2007-01-26 15:49 ` Bill Lear
2007-01-26 16:00 ` J. Bruce Fields
2007-01-26 16:07 ` Bill Lear
2007-01-26 16:06 ` Bill Lear
2007-01-26 17:19 ` Jeff King
2007-01-26 17:26 ` Jakub Narebski
2007-01-26 16:37 ` Andy Parkins
2007-01-26 17:41 ` Jakub Narebski
2007-01-26 0:17 ` Junio C Hamano
2007-01-26 21:15 ` Johannes Schindelin
2007-02-18 0:25 ` Junio C Hamano
2007-02-18 0:47 ` Johannes Schindelin
2007-02-18 1:06 ` Junio C Hamano
2007-02-18 1:15 ` Johannes Schindelin
2007-02-18 16:27 ` [PATCH for "master"] " Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr6tkdnee.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox