* [PATCH 1/7] Fix t5510-fetch's use of sed
@ 2007-03-12 22:59 Shawn O. Pearce
2007-03-12 23:06 ` Johannes Schindelin
0 siblings, 1 reply; 2+ messages in thread
From: Shawn O. Pearce @ 2007-03-12 22:59 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
POSIX says sed may add a trailing LF if there isn't already
one there. We shouldn't rely on it not adding that LF, as
some systems (Mac OS X for example) will add it.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
t/t5510-fetch.sh | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh
index ee3f397..426017e 100755
--- a/t/t5510-fetch.sh
+++ b/t/t5510-fetch.sh
@@ -134,7 +134,13 @@ test_expect_success 'bundle does not prerequisite objects' '
git add file2 &&
git commit -m add.file2 file2 &&
git bundle create bundle3 -1 HEAD &&
- sed "1,4d" < bundle3 > bundle.pack &&
+ (
+ while read x && test -n "$x"
+ do
+ :;
+ done
+ cat
+ ) <bundle3 >bundle.pack &&
git index-pack bundle.pack &&
test 4 = $(git verify-pack -v bundle.pack | wc -l)
'
--
1.5.0.3.985.gcf0b4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/7] Fix t5510-fetch's use of sed
2007-03-12 22:59 [PATCH 1/7] Fix t5510-fetch's use of sed Shawn O. Pearce
@ 2007-03-12 23:06 ` Johannes Schindelin
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Schindelin @ 2007-03-12 23:06 UTC (permalink / raw)
To: Shawn O. Pearce; +Cc: Junio C Hamano, git
Hi,
On Mon, 12 Mar 2007, Shawn O. Pearce wrote:
> POSIX says sed may add a trailing LF if there isn't already
> one there. We shouldn't rely on it not adding that LF, as
> some systems (Mac OS X for example) will add it.
>
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
ACK!
Ciao,
Dscho
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-12 23:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-12 22:59 [PATCH 1/7] Fix t5510-fetch's use of sed Shawn O. Pearce
2007-03-12 23:06 ` Johannes Schindelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox