From: Alex Riesen <raa.lkml@gmail.com>
To: Timo Sirainen <tss@iki.fi>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 3/3] Use stringbuf to clean up some string handling code.
Date: Sun, 20 May 2007 11:56:23 +0200 [thread overview]
Message-ID: <20070520095623.GA3106@steel.home> (raw)
In-Reply-To: <1179627942.32181.1288.camel@hurina>
Timo Sirainen, Sun, May 20, 2007 04:25:42 +0200:
> ---
> commit.c | 30 +++++++++++++-----------------
> local-fetch.c | 34 ++++++++++++++++------------------
> 2 files changed, 29 insertions(+), 35 deletions(-)
I find it hard to believe that it actually was a cleanup.
It is a nicer code, but... it is bigger, heavier on stack, and it does
not actually fix anything.
In my experience, such changes are seldom worth the effort. It may be
a nice code (and I actually like str.[hc]), but its use _must_ be
justified. I.e. it must simplify a complex formatting routine, or fix
a bug, which otherwise would be too hard or ugly to fix. It is
definitely not the case in this patch.
next prev parent reply other threads:[~2007-05-20 9:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-20 2:25 [PATCH 3/3] Use stringbuf to clean up some string handling code Timo Sirainen
2007-05-20 9:56 ` Alex Riesen [this message]
2007-05-20 10:04 ` Junio C Hamano
2007-05-20 11:19 ` Timo Sirainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070520095623.GA3106@steel.home \
--to=raa.lkml@gmail.com \
--cc=git@vger.kernel.org \
--cc=tss@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox