Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: Timo Sirainen <tss@iki.fi>, git@vger.kernel.org
Subject: Re: [PATCH 3/3] Use stringbuf to clean up some string handling code.
Date: Sun, 20 May 2007 03:04:59 -0700	[thread overview]
Message-ID: <7v646nq08k.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070520095623.GA3106@steel.home> (Alex Riesen's message of "Sun, 20 May 2007 11:56:23 +0200")

Alex Riesen <raa.lkml@gmail.com> writes:

> Timo Sirainen, Sun, May 20, 2007 04:25:42 +0200:
>> ---
>>  commit.c      |   30 +++++++++++++-----------------
>>  local-fetch.c |   34 ++++++++++++++++------------------
>>  2 files changed, 29 insertions(+), 35 deletions(-)
>
> I find it hard to believe that it actually was a cleanup.
>
> It is a nicer code, but... it is bigger, heavier on stack, and it does
> not actually fix anything.
>
> In my experience, such changes are seldom worth the effort. It may be
> a nice code (and I actually like str.[hc]), but its use _must_ be
> justified. I.e. it must simplify a complex formatting routine, or fix
> a bug, which otherwise would be too hard or ugly to fix. It is
> definitely not the case in this patch.

Thanks.  I was kind of waiting for somebody to say that for me
;-)

  reply	other threads:[~2007-05-20 10:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-20  2:25 [PATCH 3/3] Use stringbuf to clean up some string handling code Timo Sirainen
2007-05-20  9:56 ` Alex Riesen
2007-05-20 10:04   ` Junio C Hamano [this message]
2007-05-20 11:19   ` Timo Sirainen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7v646nq08k.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=raa.lkml@gmail.com \
    --cc=tss@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox