Git development
 help / color / mirror / Atom feed
* [StGIT PATCH] Revert 'Disallow non-patch args to "stg show" (gna #8453).'
@ 2007-07-15 21:32 Yann Dirson
  0 siblings, 0 replies; only message in thread
From: Yann Dirson @ 2007-07-15 21:32 UTC (permalink / raw)
  To: Catalin Marinas; +Cc: git

This patch has a lot of side-effects that will break people's
expectations.  There is much more that just this to do if we want to
sanitize patch/commit/range addressing on the command-line, so that
will wait till after 0.13.

Signed-off-by: Yann Dirson <ydirson@altern.org>
---

 stgit/commands/show.py |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/stgit/commands/show.py b/stgit/commands/show.py
index 2b22744..45ca253 100644
--- a/stgit/commands/show.py
+++ b/stgit/commands/show.py
@@ -55,7 +55,12 @@ def func(parser, options, args):
     elif len(args) == 0:
         patches = ['HEAD']
     else:
-        patches = parse_patches(args, applied + unapplied +\
+        if len(args) == 1 and args[0].find('..') == -1 \
+               and not crt_series.patch_exists(args[0]):
+            # it might be just a commit id
+            patches = args
+        else:
+            patches = parse_patches(args, applied + unapplied +\
                                 crt_series.get_hidden(), len(applied))
 
     if options.diff_opts:

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2007-07-15 21:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-15 21:32 [StGIT PATCH] Revert 'Disallow non-patch args to "stg show" (gna #8453).' Yann Dirson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox