From: bdowning@lavos.net (Brian Downing)
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Marius Storm-Olsen <marius@trolltech.com>,
Steffen Prohaska <prohaska@zib.de>,
dmitry.kakurin@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] Add read_cache to builtin-check-attr
Date: Tue, 14 Aug 2007 09:24:29 -0500 [thread overview]
Message-ID: <20070814142428.GK21692@lavos.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0708141506260.25989@racer.site>
On Tue, Aug 14, 2007 at 03:08:52PM +0100, Johannes Schindelin wrote:
> Shouldn't read_cache() be _only_ called if
>
> - it has not been read yet, and
> - .gitattributes was not found in the work tree?
>
> IOW check-attr is the wrong place for your patch IMHO.
I admit I just cargo-culted what builtin-checkout-index did upon starting.
Off the cuff, though, I don't see how the cache could ever already be
loaded upon the start of cmd_check_attr, and the way the attr.c code is
written, the cache be loaded when we check attributes or it will default
to the old behavior (only checking the working directory.)
What would you suggest here?
-bcd
next prev parent reply other threads:[~2007-08-14 14:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-14 13:18 [PATCH] Add read_cache to builtin-check-attr Brian Downing
2007-08-14 13:22 ` Brian Downing
2007-08-14 14:08 ` Johannes Schindelin
2007-08-14 14:24 ` Brian Downing [this message]
2007-08-14 14:46 ` Johannes Schindelin
2007-08-14 18:38 ` Junio C Hamano
2007-08-14 18:45 ` Brian Downing
2007-08-15 5:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070814142428.GK21692@lavos.net \
--to=bdowning@lavos.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=dmitry.kakurin@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marius@trolltech.com \
--cc=prohaska@zib.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox