From: Junio C Hamano <gitster@pobox.com>
To: Brian Downing <bdowning@lavos.net>
Cc: Marius Storm-Olsen <marius@trolltech.com>,
Steffen Prohaska <prohaska@zib.de>,
dmitry.kakurin@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] Add read_cache to builtin-check-attr
Date: Tue, 14 Aug 2007 11:38:24 -0700 [thread overview]
Message-ID: <7vhcn2c673.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <11870975181798-git-send-email-bdowning@lavos.net> (Brian Downing's message of "Tue, 14 Aug 2007 08:18:38 -0500")
Brian Downing <bdowning@lavos.net> writes:
> We can now read .gitattributes files out of the index, but the index
> must be loaded for this to work.
That interface is at too low a level, I am afraid. Many
commands do want to control when they read the index and it
affects the result, especially when the work tree traversal
implemented in dir.c is involved.
I am not rejecting/objecting, but just raising concerns. I do
not have time to review this today, but just wanted to see if
you fully assessed the implications (and if so that would save
work on my end).
next prev parent reply other threads:[~2007-08-14 18:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-14 13:18 [PATCH] Add read_cache to builtin-check-attr Brian Downing
2007-08-14 13:22 ` Brian Downing
2007-08-14 14:08 ` Johannes Schindelin
2007-08-14 14:24 ` Brian Downing
2007-08-14 14:46 ` Johannes Schindelin
2007-08-14 18:38 ` Junio C Hamano [this message]
2007-08-14 18:45 ` Brian Downing
2007-08-15 5:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhcn2c673.fsf@assigned-by-dhcp.cox.net \
--to=gitster@pobox.com \
--cc=bdowning@lavos.net \
--cc=dmitry.kakurin@gmail.com \
--cc=git@vger.kernel.org \
--cc=marius@trolltech.com \
--cc=prohaska@zib.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox