Git development
 help / color / mirror / Atom feed
* [PATCH] gitk: use git log --no-color vs. "diff.color = true"
@ 2007-10-10  8:58 Michele Ballabio
  0 siblings, 0 replies; only message in thread
From: Michele Ballabio @ 2007-10-10  8:58 UTC (permalink / raw)
  To: Paul Mackerras; +Cc: git, Junio C Hamano

Setting "diff.color = true" in the configuration makes "git log"
output use color codes. These aren't parsed by gitk, so use
"git log --no-color" instead.

Signed-off-by: Michele Ballabio <barra_cuda@katamail.com>
---

Yes, this is the same fix that commit eeebd8d8c5ab63494abe200b30a840aa99ee7412
applied on git-svn.

 gitk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/gitk b/gitk
index 300fdce..999e3c2 100755
--- a/gitk
+++ b/gitk
@@ -92,7 +92,7 @@ proc start_rev_list {view} {
 	set order "--date-order"
     }
     if {[catch {
-	set fd [open [concat | git log -z --pretty=raw $order --parents \
+	set fd [open [concat | git log --no-color -z --pretty=raw $order --parents \
 			 --boundary $viewargs($view) "--" $viewfiles($view)] r]
     } err]} {
 	error_popup "Error executing git rev-list: $err"
-- 
1.5.3.4

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2007-10-10  8:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-10  8:58 [PATCH] gitk: use git log --no-color vs. "diff.color = true" Michele Ballabio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox