Git development
 help / color / mirror / Atom feed
From: John Goerzen <jgoerzen@complete.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, normalperson@yhbt.net
Subject: Re: [PATCH] Fix dcommit, rebase when rewriteRoot is in use
Date: Sat, 8 Mar 2008 15:28:21 -0600	[thread overview]
Message-ID: <200803081528.21295.jgoerzen@complete.org> (raw)
In-Reply-To: <7v3ar1sz8x.fsf@gitster.siamese.dyndns.org>

On Saturday 08 March 2008 3:05:18 pm Junio C Hamano wrote:
> John Goerzen <jgoerzen@complete.org> writes:
> > Problem described here:
> >
> > http://thread.gmane.org/gmane.comp.version-control.git/76561
> >
> > Signed-off-by: John Goerzen <jgoerzen@complete.org>
>
> While I am sure Eric and git-svn users would appreciate a fix, please do
> not write a commit log message like this.
>
> Having a pointer to additional material is a very good practice, and will
> be appreciated by the readers, but giving a pointer and nothing else means
> that you are forcing your readers to hunt for out-of-line information.

Thanks for the note.  Some projects really hate long commit messages, and 
some love them, and I wasn't sure what type of project this is.

Would you like me to rewrite and re-submit this, or are you editing and 
committing?

-- John

  reply	other threads:[~2008-03-08 21:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-08 20:01 [PATCH] Fix dcommit, rebase when rewriteRoot is in use John Goerzen
2008-03-08 21:05 ` Junio C Hamano
2008-03-08 21:28   ` John Goerzen [this message]
2008-03-08 21:52     ` Eric Wong
2008-03-08 21:32 ` Johannes Schindelin
2008-03-08 22:04   ` John Goerzen
  -- strict thread matches above, loose matches on Subject: below --
2008-03-08 22:04 John Goerzen
2008-03-08 22:22 ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803081528.21295.jgoerzen@complete.org \
    --to=jgoerzen@complete.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=normalperson@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox