From: Junio C Hamano <gitster@pobox.com>
To: John Goerzen <jgoerzen@complete.org>
Cc: git@vger.kernel.org, normalperson@yhbt.net
Subject: Re: [PATCH] Fix dcommit, rebase when rewriteRoot is in use
Date: Sat, 08 Mar 2008 13:05:18 -0800 [thread overview]
Message-ID: <7v3ar1sz8x.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1205006470-18882-1-git-send-email-jgoerzen@complete.org> (John Goerzen's message of "Sat, 8 Mar 2008 14:01:10 -0600")
John Goerzen <jgoerzen@complete.org> writes:
> Problem described here:
>
> http://thread.gmane.org/gmane.comp.version-control.git/76561
>
> Signed-off-by: John Goerzen <jgoerzen@complete.org>
While I am sure Eric and git-svn users would appreciate a fix, please do
not write a commit log message like this.
Having a pointer to additional material is a very good practice, and will
be appreciated by the readers, but giving a pointer and nothing else means
that you are forcing your readers to hunt for out-of-line information.
One person who writes can spend an extra few minutes to summarize the
issue, and it will save time and effort for hundreds of readers.
If what is written is worth being read by that many readers, that is, and
in this case I am sure it is ;-).
next prev parent reply other threads:[~2008-03-08 21:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-08 20:01 [PATCH] Fix dcommit, rebase when rewriteRoot is in use John Goerzen
2008-03-08 21:05 ` Junio C Hamano [this message]
2008-03-08 21:28 ` John Goerzen
2008-03-08 21:52 ` Eric Wong
2008-03-08 21:32 ` Johannes Schindelin
2008-03-08 22:04 ` John Goerzen
-- strict thread matches above, loose matches on Subject: below --
2008-03-08 22:04 John Goerzen
2008-03-08 22:22 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v3ar1sz8x.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jgoerzen@complete.org \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox