From: Jeff King <peff@peff.net>
To: Avery Pennarun <apenwarr@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/3 v2] Add --blob-filter option to filter-branch.
Date: Wed, 23 Apr 2008 21:33:00 -0400 [thread overview]
Message-ID: <20080424013259.GA31146@sigill.intra.peff.net> (raw)
In-Reply-To: <32541b130804231507l4aff2ca3x962bf385a409685b@mail.gmail.com>
On Wed, Apr 23, 2008 at 06:07:03PM -0400, Avery Pennarun wrote:
> I think it would be fine to index into the cache using $path$sha1,
> which would seem to resolve this issue. The catch is that $path isn't
> a very good cachefile name. I'd suggest doing an md5sum or something
> on it, but that would result in an extra fork for every file, which
> brings us back to our original level of slowness (or worse).
>
> Hmm, I gues using a cachefile like $sha1/$path would work; it requires
> a "mkdir -p", but only when *filling* the cache.
Keep in mind that $path can have slashes. So you actually need to:
mkdir -p `dirname $sha1/$path`
echo $new >$sha1/$path
-Peff
prev parent reply other threads:[~2008-04-24 1:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-23 19:42 [PATCH 1/3] Add --blob-filter option to filter-branch Avery Pennarun
2008-04-23 19:42 ` [PATCH 2/3] Make filter-branch --glob-filter much faster by not calling 'cat' Avery Pennarun
2008-04-23 19:42 ` [PATCH 3/3] Update documentation to describe git filter-branch --blob-filter Avery Pennarun
2008-04-23 20:05 ` [PATCH 1/3] Add --blob-filter option to filter-branch Johannes Schindelin
2008-04-23 20:12 ` Avery Pennarun
2008-04-23 20:14 ` Johannes Schindelin
2008-04-23 20:18 ` [PATCH 1/3 v2] " Avery Pennarun
2008-04-23 20:22 ` Johannes Schindelin
2008-04-23 21:55 ` Jeff King
2008-04-23 22:07 ` Avery Pennarun
2008-04-24 1:33 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080424013259.GA31146@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=apenwarr@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox