Git development
 help / color / mirror / Atom feed
From: "Avery Pennarun" <apenwarr@gmail.com>
To: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, "Jeff King" <peff@peff.net>
Subject: Re: [PATCH 1/3] Add --blob-filter option to filter-branch.
Date: Wed, 23 Apr 2008 16:12:25 -0400	[thread overview]
Message-ID: <32541b130804231312n50e86ce6g2b2331ca514ba982@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0804232104160.20267@eeepc-johanness>

On 4/23/08, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> Not all of this belongs in the commit messaage.
>
>  > Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> This does.
>
>  A good general rule is: if you think it would be funny/strange to read
>  this message in the output of "git log", it should be changed.

I felt uncomfortable modifying the message attached to Jeff's patch
(which actually does pretty clearly explain what's going on), since
it's not mine.  If he wants to send me a better commit message,
that'll be fine too.

Have fun,

Avery

  reply	other threads:[~2008-04-23 20:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-23 19:42 [PATCH 1/3] Add --blob-filter option to filter-branch Avery Pennarun
2008-04-23 19:42 ` [PATCH 2/3] Make filter-branch --glob-filter much faster by not calling 'cat' Avery Pennarun
2008-04-23 19:42   ` [PATCH 3/3] Update documentation to describe git filter-branch --blob-filter Avery Pennarun
2008-04-23 20:05 ` [PATCH 1/3] Add --blob-filter option to filter-branch Johannes Schindelin
2008-04-23 20:12   ` Avery Pennarun [this message]
2008-04-23 20:14     ` Johannes Schindelin
2008-04-23 20:18       ` [PATCH 1/3 v2] " Avery Pennarun
2008-04-23 20:22         ` Johannes Schindelin
2008-04-23 21:55         ` Jeff King
2008-04-23 22:07           ` Avery Pennarun
2008-04-24  1:33             ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32541b130804231312n50e86ce6g2b2331ca514ba982@mail.gmail.com \
    --to=apenwarr@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox