multiple files for the same hook

multiple files for the same hook

[Thomas Hunger]

Hi,

we use hooks a lot for various cleanup tasks, tests and warnings. It 
would be wonderful if we could keep the hook logic in separate files. 

Something like

    hooks/post-commit.d/

where all executable files in the dir are executed in alphanumeric 
order. Is there a possibility of this going into git (I could try a 
patch)?

Tom

Re: multiple files for the same hook

[Sverre Rabbelier]

On Mon, May 12, 2008 at 10:39 PM, Thomas Hunger <hto@arcor.de> wrote:
>  where all executable files in the dir are executed in alphanumeric
>  order. Is there a possibility of this going into git (I could try a
>  patch)?

Heya,

Wouldn't it be easy to have the hook script do that?
Just have it walk through the directory and call all the scripts?

-- 
Cheers,

Sverre Rabbelier

Re: multiple files for the same hook

[Miklos Vajna]

[-- Attachment #1: Type: text/plain, Size: 644 bytes --]

On Mon, May 12, 2008 at 08:39:49PM +0000, Thomas Hunger <hto@arcor.de> wrote:
> we use hooks a lot for various cleanup tasks, tests and warnings. It 
> would be wonderful if we could keep the hook logic in separate files. 
> 
> Something like
> 
>     hooks/post-commit.d/
> 
> where all executable files in the dir are executed in alphanumeric 
> order. Is there a possibility of this going into git (I could try a 
> patch)?

why would you want so? just create a script named hooks/post-commit,
like:

----
#!/bin/sh
/path/to/first/script
/path/to/second/script
----

or so.

it's not something git should do for you.

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

Re: multiple files for the same hook

[Thomas Hunger]

Miklos, Sverre,

> why would you want so? just create a script named
> hooks/post-commit, like:

you are right, it's what we actually do, using --template to set up 
our own scripts. If nobody but us needs this it's certainly not worth 
bothering.

Thanks
Tom

Re: multiple files for the same hook

[Jeff King]

On Mon, May 12, 2008 at 09:56:30PM +0000, Thomas Hunger wrote:

> > why would you want so? just create a script named
> > hooks/post-commit, like:
> 
> you are right, it's what we actually do, using --template to set up 
> our own scripts. If nobody but us needs this it's certainly not worth 
> bothering.

The problem is that the semantics of calling some of the hooks is not as
simple as just calling them all in a row. How do you split up the input
going to the hooks? How do you combine the output coming from the hooks?
What is the resulting exit code? If one hook fails, do we indicate
failure? Or if one hook succeeds, do we indicate success?

So before any such code could go into git proper, there would have to be
agreement on how those issues are resolved. In the meantime, it probably
makes more sense to implement a "master" post-commit hook that uses the
semantics that you find useful.

-Peff

Re: multiple files for the same hook

[Martin Langhoff]

On Tue, May 13, 2008 at 4:21 PM, Jeff King <peff@peff.net> wrote:
>  In the meantime, it probably
>  makes more sense to implement a "master" post-commit hook that uses the
>  semantics that you find useful.

And when you are implementing those semantics, you might be able to
reuse "run-parts" which does roughly what you want.

:-)

cheers,



m
--
 martin.langhoff@gmail.com
 martin@laptop.org -- School Server Architect
 - ask interesting questions
 - don't get distracted with shiny stuff - working code first
 - http://wiki.laptop.org/go/User:Martinlanghoff