Git development
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Alexander Gavrilov <angavrilov@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH] Support gitlinks in fast-import/export.
Date: Fri, 18 Jul 2008 15:43:38 -0500	[thread overview]
Message-ID: <20080718204338.GB27528@spearce.org> (raw)
In-Reply-To: <200807182103.37272.angavrilov@gmail.com>

Alexander Gavrilov <angavrilov@gmail.com> wrote:
> Currently fast-import/export cannot be used for
> repositories with submodules. This patch extends
> the relevant programs to make them correctly
> process gitlinks.
> 
> Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>

Acked-by: Shawn O. Pearce <spearce@spearce.org>

> 	I noticed that fast-export & fast-import cannot work with
> 	repositories using submodules: import complains about
> 	an invalid mode, and export fails while trying to open the SHA
> 	as a blob.
> 
> 	As I didn't see any particular reason for it to be so, I tried to
> 	implement support for gitlinks.
> 
> 	What I'm unsure of is, should fast-export try to reuse commit
> 	marks for gitlinks where it happened to recognize the object,
> 	or always output the SHA as it is stored in the tree?

Its unlikely that the commit objects are in the repository the
export is running in, so its unlikely you can use a mark.  Its
fine to just always output the SHA-1 I think.

-- 
Shawn.

  parent reply	other threads:[~2008-07-18 20:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-18 17:03 [RFC PATCH] Support gitlinks in fast-import/export Alexander Gavrilov
2008-07-18 17:36 ` Johannes Schindelin
2008-07-18 18:34   ` Alexander Gavrilov
2008-07-18 23:21     ` Johannes Schindelin
2008-07-18 20:43 ` Shawn O. Pearce [this message]
2008-07-19  1:22   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080718204338.GB27528@spearce.org \
    --to=spearce@spearce.org \
    --cc=angavrilov@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox