From: Johannes Schindelin <Johannes.Schindelin@gmx.de>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Alexander Gavrilov <angavrilov@gmail.com>, git@vger.kernel.org
Subject: Re: [RFC PATCH] Support gitlinks in fast-import/export.
Date: Sat, 19 Jul 2008 03:22:16 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.1.00.0807190321040.3064@eeepc-johanness> (raw)
In-Reply-To: <20080718204338.GB27528@spearce.org>
Hi,
On Fri, 18 Jul 2008, Shawn O. Pearce wrote:
> Alexander Gavrilov <angavrilov@gmail.com> wrote:
>
> > I noticed that fast-export & fast-import cannot work with
> > repositories using submodules: import complains about an invalid
> > mode, and export fails while trying to open the SHA as a blob.
> >
> > As I didn't see any particular reason for it to be so, I tried to
> > implement support for gitlinks.
> >
> > What I'm unsure of is, should fast-export try to reuse commit
> > marks for gitlinks where it happened to recognize the object, or
> > always output the SHA as it is stored in the tree?
>
> Its unlikely that the commit objects are in the repository the export is
> running in, so its unlikely you can use a mark. Its fine to just always
> output the SHA-1 I think.
Oh, I just realized that fast-import expects changes, instead of full
snapshots.
So strike all my suggestions regarding gitlink marks.
Sorry,
Dscho
prev parent reply other threads:[~2008-07-19 1:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 17:03 [RFC PATCH] Support gitlinks in fast-import/export Alexander Gavrilov
2008-07-18 17:36 ` Johannes Schindelin
2008-07-18 18:34 ` Alexander Gavrilov
2008-07-18 23:21 ` Johannes Schindelin
2008-07-18 20:43 ` Shawn O. Pearce
2008-07-19 1:22 ` Johannes Schindelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.1.00.0807190321040.3064@eeepc-johanness \
--to=johannes.schindelin@gmx.de \
--cc=angavrilov@gmail.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox