From: Jeff King <peff@peff.net>
To: Anders Melchiorsen <mail@cup.kalibalik.dk>
Cc: Junio C Hamano <gitster@pobox.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
git@vger.kernel.org
Subject: Re: [BUG] git ls-files -m --with-tree does double output
Date: Fri, 26 Sep 2008 18:50:43 -0400 [thread overview]
Message-ID: <20080926225043.GC24817@coredump.intra.peff.net> (raw)
In-Reply-To: <87od2dv7mz.fsf@cup.kalibalik.dk>
On Wed, Sep 24, 2008 at 06:19:32PM +0200, Anders Melchiorsen wrote:
> I think that this is wrong? The combination of -m and --with-tree
> shows duplicate entries. Git 1.6.0.2.
I have confirmed this, and it looks like it has always been that way. It
looks like overlay_tree_on_cache just does a read_tree to pull the tree
into the index, and then we end up with duplicate entries.
I'm not too familiar with the read_tree code, so I am cc'ing Junio (who
is out of touch for a little while) and Linus, who are much more clueful
in this area.
It isn't clear to me which code is _supposed_ to be pulling out such
duplicates here. That is, is read_tree broken, or is
overlay_tree_on_cache just calling it wrong?
-Peff
next prev parent reply other threads:[~2008-09-26 22:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-24 16:19 [BUG] git ls-files -m --with-tree does double output Anders Melchiorsen
2008-09-26 22:50 ` Jeff King [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-11-13 21:53 Anders Melchiorsen
2008-11-13 22:35 ` Junio C Hamano
2008-11-13 22:39 ` Junio C Hamano
2008-11-13 23:11 ` Anders Melchiorsen
2008-11-16 8:03 ` Junio C Hamano
2008-11-16 9:00 ` Anders Melchiorsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080926225043.GC24817@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mail@cup.kalibalik.dk \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox