Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Anders Melchiorsen" <mail@cup.kalibalik.dk>
Cc: gitster@pobox.com, git@vger.kernel.org
Subject: Re: [BUG] git ls-files -m --with-tree does double output
Date: Thu, 13 Nov 2008 14:35:22 -0800	[thread overview]
Message-ID: <7vod0jfe51.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <37512.N1gUGH5fRhE=.1226613228.squirrel@webmail.hotelhot.dk> (Anders Melchiorsen's message of "Thu, 13 Nov 2008 22:53:48 +0100 (CET)")

"Anders Melchiorsen" <mail@cup.kalibalik.dk> writes:

> and@dylle:~/repo$ git ls-files -m --with-tree=HEAD
> a
> a
>
>
> Jeff King added:
> ...
> It isn't clear to me which code is _supposed_ to be pulling out such
> duplicates here. That is, is read_tree broken, or is
> overlay_tree_on_cache just calling it wrong?

I had to look up what -m meant in ls-files, as I never considered that
option as part of the plumbing.

What's the use case of using -m together with --with-tree to begin with?
I think the only sensible other option that makes sense with --with-tree
is --error-unmatch.

  reply	other threads:[~2008-11-13 22:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-13 21:53 [BUG] git ls-files -m --with-tree does double output Anders Melchiorsen
2008-11-13 22:35 ` Junio C Hamano [this message]
2008-11-13 22:39   ` Junio C Hamano
2008-11-13 23:11   ` Anders Melchiorsen
2008-11-16  8:03     ` Junio C Hamano
2008-11-16  9:00       ` Anders Melchiorsen
  -- strict thread matches above, loose matches on Subject: below --
2008-09-24 16:19 Anders Melchiorsen
2008-09-26 22:50 ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vod0jfe51.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mail@cup.kalibalik.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox