From: Jeff King <peff@peff.net>
To: Clemens Buchacher <drizzd@aon.at>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] push: fix local refs update if already up-to-date
Date: Wed, 5 Nov 2008 17:44:51 -0500 [thread overview]
Message-ID: <20081105224450.GA20440@coredump.intra.peff.net> (raw)
In-Reply-To: <20081105202849.GA9484@localhost>
On Wed, Nov 05, 2008 at 09:28:49PM +0100, Clemens Buchacher wrote:
> The reason it doesn't work is a bug in lock_ref_sha1_basic(). Dating back to
> pre-"pack-refs" times, this code forces a write if the ref file does not
> exist. I will resubmit the patch including your above testcase and a bugfix
> for lock_ref_sha1_basic().
OK, thanks for looking into it further. Both patches look sane to me.
-Peff
next prev parent reply other threads:[~2008-11-05 22:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-04 0:07 [PATCH] push: fix local refs update if already up-to-date Clemens Buchacher
2008-11-04 4:26 ` Jeff King
2008-11-04 8:38 ` Junio C Hamano
2008-11-04 9:05 ` Clemens Buchacher
2008-11-04 8:56 ` Clemens Buchacher
2008-11-05 2:49 ` Jeff King
2008-11-05 20:28 ` Clemens Buchacher
2008-11-05 20:55 ` [PATCH 1/2] do not force write of packed refs Clemens Buchacher
2008-11-05 20:55 ` [PATCH 2/2] push: fix local refs update if already up-to-date Clemens Buchacher
2008-11-05 21:57 ` [PATCH] " Clemens Buchacher
2008-11-05 22:23 ` Junio C Hamano
2008-11-05 22:44 ` Jeff King [this message]
2008-11-04 20:57 ` [PATCH v2] " Clemens Buchacher
2008-11-05 2:51 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081105224450.GA20440@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox