Git development
 help / color / mirror / Atom feed
* [PATCH (GIT-GUI)] git-gui: Fix the search bar destruction handler.
@ 2008-11-13 18:52 Alexander Gavrilov
  0 siblings, 0 replies; only message in thread
From: Alexander Gavrilov @ 2008-11-13 18:52 UTC (permalink / raw)
  To: git; +Cc: Shawn O. Pearce

Since delete_this is an ordinary function, it
should not be passed to cb; otherwise it produces
errors when blame windows are closed. Unfortunately,
it is not noticeable when blame is shown in the
master window, so I missed this bug.

Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>
---
 lib/search.tcl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib/search.tcl b/lib/search.tcl
index 32c8656..b371e9a 100644
--- a/lib/search.tcl
+++ b/lib/search.tcl
@@ -35,7 +35,7 @@ constructor new {i_w i_text args} {
 
 	trace add variable searchstring write [cb _incrsearch_cb]
 	
-	bind $w <Destroy> [cb delete_this]
+	bind $w <Destroy> [list delete_this $this]
 	return $this
 }
 
-- 
1.6.0.3.15.gb8d36

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2008-11-13 18:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-13 18:52 [PATCH (GIT-GUI)] git-gui: Fix the search bar destruction handler Alexander Gavrilov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox